balancer / balancer-v3-monorepo

GNU General Public License v3.0

24 stars 4 forks source link

Improve test coverage for VaultAdmin.sol #732

Closed joaobrunoah closed 6 days ago

joaobrunoah commented 1 week ago

Description

This PR improves the test coverage for VaultAdmin.sol. To identify what should be tested, I ran yarn coverage inside vault package.

Note: If hardhat and forge tests are merged, the branch coverage report breaks. So, I adapted coverage.sh to not consider hardhat input.

Type of change

[ ] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Dependency changes
[ ] Code refactor / cleanup
[ ] Documentation or wording changes
[x] Other

Checklist:

[x] The diff is legible and has no extraneous changes
[x] Complex code has been commented, including external interfaces
[x] Tests have 100% code coverage
[x] The base branch is either main, or there's a description of how to merge

Issue Resolution

Closes #716