There are a couple places where we round balances up, and it's not clear this is the right thing to do. It also introduces a possible discrepancy between the public getter for live balances (which doesn't expose the rounding direction, and always rounds down), and what the live code would do. (Though we don't think this is consequential.)
Type of change
[ ] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Dependency changes
[X] Code refactor / cleanup
[ ] Documentation or wording changes
[ ] Other
Checklist:
[X] The diff is legible and has no extraneous changes
[ ] Complex code has been commented, including external interfaces
[ ] Tests have 100% code coverage
[X] The base branch is either main, or there's a description of how to merge
Description
There are a couple places where we round balances up, and it's not clear this is the right thing to do. It also introduces a possible discrepancy between the public getter for live balances (which doesn't expose the rounding direction, and always rounds down), and what the live code would do. (Though we don't think this is consequential.)
Type of change
Checklist:
main, or there's a description of how to mergeIssue Resolution
Resolves #152