Variant of minimum Guardrails built on #748 , which allows 0-value swaps. This removes the special case we'd otherwise need for donations. It also allows 100% fees (but not near 100% fees that would result in small trades. So I'm not sure this is really better. It allows exactly 100%, but there is a "gap" of disallowed values that you'd have to calculate (see the corresponding test: FixedPoint.ONE - MIN_TRADE_AMOUNT.divDown(defaultAmount)).
Type of change
[ ] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Dependency changes
[X] Code refactor / cleanup
[ ] Optimization: [ ] gas / [ ] bytecode
[ ] Documentation or wording changes
[ ] Other
Checklist:
[X] The diff is legible and has no extraneous changes
[ ] Complex code has been commented, including external interfaces
[ ] Tests have 100% code coverage
[X] The base branch is either main, or there's a description of how to merge
Description
Variant of minimum Guardrails built on #748 , which allows 0-value swaps. This removes the special case we'd otherwise need for donations. It also allows 100% fees (but not near 100% fees that would result in small trades. So I'm not sure this is really better. It allows exactly 100%, but there is a "gap" of disallowed values that you'd have to calculate (see the corresponding test:
FixedPoint.ONE - MIN_TRADE_AMOUNT.divDown(defaultAmount)).Type of change
Checklist:
main, or there's a description of how to mergeIssue Resolution