balancer / balancer-v3-monorepo

GNU General Public License v3.0

37 stars 10 forks source link

Removing redundant check from Router.sol #752

Closed joaobrunoah closed 2 months ago

joaobrunoah commented 2 months ago

Description

The vault already checks if amountsOut are greater than minimum, the router does not need to check again.

Type of change

[ ] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Dependency changes
[x] Code refactor / cleanup
[ ] Optimization: [ ] gas / [ ] bytecode
[ ] Documentation or wording changes
[ ] Other

Checklist:

[x] The diff is legible and has no extraneous changes
[x] Complex code has been commented, including external interfaces
[x] Tests have 100% code coverage
[x] The base branch is either main, or there's a description of how to merge