It took us a second to successfully prank static calls (you have to set the tx.origin to 0 as well, which is the seldom-used second argument to prank), and we weren't commenting that consistently.
This PR factors out that prank call (and comment) to an internal function of BaseVaultTest, so that we can just say _prankStaticCall(); everywhere.
Type of change
[ ] Bug fix
[X] New feature
[ ] Breaking change
[ ] Dependency changes
[ ] Code refactor / cleanup
[ ] Optimization: [ ] gas / [ ] bytecode
[ ] Documentation or wording changes
[ ] Other
Checklist:
[X] The diff is legible and has no extraneous changes
[ ] Complex code has been commented, including external interfaces
[ ] Tests have 100% code coverage
[X] The base branch is either main, or there's a description of how to merge
Description
It took us a second to successfully prank static calls (you have to set the
tx.originto 0 as well, which is the seldom-used second argument to prank), and we weren't commenting that consistently.This PR factors out that prank call (and comment) to an internal function of
BaseVaultTest, so that we can just say_prankStaticCall();everywhere.Type of change
Checklist:
main, or there's a description of how to mergeIssue Resolution