balancer / balancer-v3-monorepo

GNU General Public License v3.0

38 stars 10 forks source link

Hooks example modifiers #772

Closed EndymionJkb closed 2 months ago

EndymionJkb commented 2 months ago

Description

In the course of reviews, it seems the hook examples were missing some of the modifiers. (And we don't really need them on the abstract base contract, as they'd never be called.)

Type of change

[ ] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Dependency changes
[X] Code refactor / cleanup
[ ] Optimization: [ ] gas / [ ] bytecode
[ ] Documentation or wording changes
[ ] Other

Checklist:

[X] The diff is legible and has no extraneous changes
[ ] Complex code has been commented, including external interfaces
[ ] Tests have 100% code coverage
[X] The base branch is either main, or there's a description of how to merge

Issue Resolution

joaobrunoah commented 2 months ago

@EndymionJkb , most of the hooks will be implemented by external developers, who may forget to ad onlyVault. Is onlyVault modifier really required for hooks? I mean, what happens if the hook does not implement this modifier?