Minimize storage reads in WeightedPool::computeBalance

[gerrrg]

Description

Currently, calling computeBalance() can perform (at most) 8 storage reads since it's calling _getNormalizedWeights() and then taking the ith index. Instead, we can directly query _getNormalizedWeight(i) and just perform a single storage read for the weight we want.

Type of change

• [ ] Bug fix
• [ ] New feature
• [ ] Breaking change
• [ ] Dependency changes
• [ ] Code refactor / cleanup
• [x] Optimization: [x] gas / [ ] bytecode
• [ ] Documentation or wording changes
• [ ] Other

Checklist:

• [x] The diff is legible and has no extraneous changes
• [x] Complex code has been commented, including external interfaces
• [x] Tests have 100% code coverage
• [x] The base branch is either main, or there's a description of how to merge

Issue Resolution

[EndymionJkb]

Hmmm! Good catch; certainly seems like this should work. I don't believe we ever call this, which is one reason we never noticed. Should have a test. (We would have found that in the coverage tests I suppose.)

[gerrrg]

Ah, yeah good point @jubeira about immutable reads vs normal storage reads. Still seems like a good thing to add in, just not as significant as I initially thoughts 🙂