Found a lot of stuff looking at generalizing Weighted Pool tests.
One is an out-dated comment saying you can't access immutables in constructors or if statements. Was true when originally written in v2 - but you can do it with modern Solidity.
Type of change
[ ] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Dependency changes
[X] Code refactor / cleanup
[ ] Optimization: [ ] gas / [ ] bytecode
[ ] Documentation or wording changes
[ ] Other
Checklist:
[X] The diff is legible and has no extraneous changes
[N/A] Complex code has been commented, including external interfaces
[ ] Tests have 100% code coverage
[X] The base branch is either main, or there's a description of how to merge
Description
Found a lot of stuff looking at generalizing Weighted Pool tests.
One is an out-dated comment saying you can't access immutables in constructors or if statements. Was true when originally written in v2 - but you can do it with modern Solidity.
Type of change
Checklist:
main, or there's a description of how to mergeIssue Resolution