balancer / balancer-v3-monorepo

GNU General Public License v3.0
37 stars 10 forks source link

Use standard dai/usdc for e2e #827

Closed EndymionJkb closed 1 month ago

EndymionJkb commented 1 month ago

Description

This uses token1/2 and has a custom sort. I wondered if there was a reason to do this vs. just using dai/usdc and the common sort like other tests, and there doesn't seem to be.

Merge into #801 if I'm not missing something.

Type of change

Checklist:

Issue Resolution

joaobrunoah commented 1 month ago

Hey @EndymionJkb ! Since the idea is that this is a base test for other tests, and could be extended to fork tests too with small adjustments, I thought it'd be better to don't use dai/usdc directly here, and use variables for the tokens instead. But I'll use tokenA/tokenB instead of the numbers, as you suggested in the other PR.

EndymionJkb commented 1 month ago

Primary PR will be modified as described above.