search

balancer / dune-spellbook

SQL views for Dune Analytics
Other
7 stars 12 forks source link

add protocol fee spell to fantom #85

Closed mendesfabio closed 3 weeks ago

mendesfabio commented 1 month ago

ProtocolFeeCollector: https://ftmscan.com/address/0xc6920d3a369e7c8bd1a22dbe385e11d1f7af948f

mendesfabio commented 1 month ago

this dashboard is helpful for cross-checking. it seems a bunch of fees are collected in BPTs so we need their prices as well to have accurate numbers.

viniabussafi commented 1 month ago

Working on a PR

viniabussafi commented 1 month ago

Initial tests passed, but still a long way to go (about 5x) on fees collected, probably due to missing tokens on prices.usd. Will work on it.

viniabussafi commented 1 month ago

Turns out it is due to missing pool factories, for which franz has created a PR. WIll proceed with my PR and once Franz' one gets merged, results should be as expected.

viniabussafi commented 1 month ago

ready to merge

viniabussafi commented 3 weeks ago

PR merged - need to validate data, will wait for one more run of the spell tonight

viniabussafi commented 3 weeks ago

Both mine and franz' pr were merged, spells ran today and numbers look good