search

balancer / frontend-v2

Frontend app for the Balancer protocol
https://app.balancer.fi
MIT License
186 stars 301 forks source link

Bug: when creating a new pool, if the creation process is interrupted user is unable to complete the creation process #4526

Open sambacha opened 9 months ago

sambacha commented 9 months ago

Describe the bug

  1. Create a new weighted pool
    • 80%
    • 20%
  2. Set pool fees
  3. Set initial Liquidity
  4. Confirm Pool Creation

To Reproduce Steps to reproduce the behavior:

At step 3, exit the browser entirely. Re-login with a new browser instance, and try to fund the pool liquidity ('Join Pool')

We are unable to 'Join Pool' due to 

MetaMask - RPC Error: execution reverted: BAL#103

This is because the user is brought to the CONFIRMATION page for funding the pool, the user instead should be sent back to the 'Set Initial Liquidity page' to recalculate the weight amounts for the respective tokens, as the state is not retained from the first calculation.

Expected behavior

Have the user re-calculate the liquidity amounts and put them back on the 'Set initial liquidity page'

sambacha commented 9 months ago

Attached are the log output of the errors and a screenshot of the page that the user is brought back to upon trying to resume pool creation

app.balancer.fi-1699292984770.zip

Screenshot 2023-11-06 at 9 52 18 AM
garethfuller commented 9 months ago

Thanks for providing the details here @sambacha, we'll try to fix asap.