balansse / google-meet-jabra

Chrome Extension that adds Jabra call control support to Google Meet.
MIT License
23 stars 2 forks source link

Mute button doesn't work #16

Open chrispennel opened 1 year ago

chrispennel commented 1 year ago

I use it with Chrome 115.0.5790.170 arm64 on MacOS Version 13.5 (22G74) I use Jabra SPEAK 510 USB, correctly detected by the extension. Exit meeting work, but mute sync and mute Meet from the button doesn't work. Extension release: 1.4.1

socram70 commented 11 months ago

This also doesn't work with my Evolve2 65. Leaving the call with the center button works though. Version 118.0.5993.88 (Official Build) (arm64) Version 1.4.1 of the extension

sebastienraillet commented 10 months ago

After investigating a bit on my side and recompiling the extension by myself, the issue seems to be due to the way the html element of the mute button is recovered here :

const micToggleButton = () => document.querySelector('button[aria-label*="+ d)"]');

At least, on the "French" version of Google Meet, the button label is without the space between '+' and 'd' :

aria-label="Désactiver le micro (⌘+d)"

By removing the space, I was able to get the extension working properly on my side.

@socram70 and @chrispennel, for your information, trying to investigate this issue, I discovered Google Meet is now supporting out of the box a list of some headsets (see here). This list of certified hardware (where many Jabra products are part of) allow to get all the feature proposed by this extension natively in Google Meet. See this documentation to activate it 😃

Even if I'm now no more using this extension based on the above sentence, I would like to thank @balansse for the sharing of this extension and the work made ! I'm also a software developer and it is always appreciated when someone share its work with the community 👍

socram70 commented 10 months ago

Thanks for highlighting me. It seems the extension is not needed anymore in a lot of cases. I accidentally discovered the new feature in Google Meet today too ans it seems to work properly out of the box now.

khunst commented 10 months ago

I am trying this with Jabra Elite 7 active, but it doesn't find the device. Windows 11.