search

balapi / netconf-polt

netconf server for use with BAL API
Apache License 2.0
6 stars 3 forks source link

Any plan for upgrading to sysrepo and libyang version 2 #12

Closed wdl2015 closed 1 year ago

wdl2015 commented 2 years ago

Hi team,

Could you let know if there is a plan to upgrade netconf-polt to use latest libnetconf2, sysrepo, and libyang to latest version 2 in the near future? Thanks a lot.

Br George

igortern commented 2 years ago

Hi George, The develop branch uses netopeer2 2.1.16 which isn't the latest version, but 1 before last. AFAIK there were massive changes in netopeer2 2.1.23 & companion packages because it is the 1st version supporting schema mount. I prefer to wait a bit until dust settles, unless there is a specific bug in 2.1.16 that was fixed in 2.1.23 or need to use the schema mount. BR Igor

wdl2015 commented 2 years ago

Hi Igor,

Thanks a lot for your quick comments.

I downloaded the latest netconf-polt master from github https://github.com/balapi/netconf-polt It can make successfully with below command. Looking into the build/third_party folder it is using sysrepo 1.4.140 and libyang 1.0.240, not version 2.0.

_make NETCONF_SERVER=y NO_BAL=n TR451_VOMCI_POLT=n SIMULATIONBUILD=n

Due to there might be a defect in libyang 1.0.240 (https://github.com/CESNET/libyang/issues/1847) we would like to use libyang 2.0. Saw there is a parameter "NETOPEER2_VERSION_2X" for building netconf-polt with libyang 2.0. Change the command line to below.

_make NETOPEER2_VERSION_2X=y NETCONF_SERVER=y NO_BAL=n TR451_VOMCI_POLT=n SIMULATIONBUILD=n

It is true sysrepo 2.0.1 and libyang 2.0.7 is used with NETOPEER2_VERSION_2X=y. During the build there is below error reported. Could you help a check if I missed anything? Is this the correct command line for enabling libyang 2.0? Thanks a lot!

[100%] Linking C executable notif_subscribe_example /usr/bin/ld: warning: libyang.so.1, needed by ../libsysrepo.so.6.0.1, may conflict with libyang.so.2 [100%] Built target notif_subscribe_example Install the project... -- Install configuration: "Debug" -- Installing: /home/georgede/rje/netconf-polt-master/build/fs/lib/libsysrepo.so.6.0.1 -- Installing: /home/georgede/rje/netconf-polt-master/build/fs/lib/libsysrepo.so.6 -- Installing: /home/georgede/rje/netconf-polt-master/build/fs/lib/libsysrepo.so -- Set runtime path of "/home/georgede/rje/netconf-polt-master/build/fs/lib/libsysrepo.so.6.0.1" to "" -- Installing: /home/georgede/rje/netconf-polt-master/build/fs/include/sysrepo.h -- Installing: /home/georgede/rje/netconf-polt-master/build/fs/include/sysrepo_types.h -- Installing: /home/georgede/rje/netconf-polt-master/build/fs/include/values.h -- Installing: /home/georgede/rje/netconf-polt-master/build/fs/include/xpath.h -- Up-to-date: /home/georgede/rje/netconf-polt-master/build/fs/include/sysrepo.h -- Up-to-date: /home/georgede/rje/netconf-polt-master/build/fs/include/sysrepo_types.h -- Installing: /home/georgede/rje/netconf-polt-master/build/fs/include/sysrepo/version.h -- Installing: /home/georgede/rje/netconf-polt-master/build/fs/include/sysrepo/values.h -- Installing: /home/georgede/rje/netconf-polt-master/build/fs/include/sysrepo/xpath.h -- Installing: /home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepoctl -- Set runtime path of "/home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepoctl" to "" -- Installing: /home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepocfg -- Set runtime path of "/home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepocfg" to "" -- Installing: /home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepo-plugind -- Set runtime path of "/home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepo-plugind" to "" -- Installing: /home/georgede/rje/netconf-polt-master/build/fs/lib/pkgconfig/sysrepo.pc [ 31%] Built target sysrepo_2.0.1 Scanning dependencies of target yang-models-push-scheduled-changes [ 32%] Generating .ietf-pseudowires@2018-10-22.installed /home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepotool.sh /home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepoctl --install /home/georgede/rje/netconf-polt-master/third_party/yang-models/OB-BAA-standard-olt-adapter/2.0/yang/ietf-pseudowires@2018-10-22.yang -a --search-dirs /home/georgede/rje/netconf-polt-master/third_party/yang-models/OB-BAA-standard-olt-adapter/2.0/yang:/home/georgede/rje/netconf-polt-master/third_party/yang-models/IETF_IANA /home/georgede/rje/netconf-polt-master/third_party/yang-models/OB-BAA-standard-olt-adapter/2.0/yang/ietf-pseudowires@2018-10-22.yang imported to sysrepo [ 32%] Generating .bbf-qos-composite-filters.installed /home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepotool.sh /home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepoctl --install /home/georgede/rje/netconf-polt-master/third_party/yang-models/OB-BAA-standard-olt-adapter/2.0/yang/bbf-qos-composite-filters.yang -a --search-dirs /home/georgede/rje/netconf-polt-master/third_party/yang-models/OB-BAA-standard-olt-adapter/2.0/yang:/home/georgede/rje/netconf-polt-master/third_party/yang-models/IETF_IANA /home/georgede/rje/netconf-polt-master/third_party/yang-models/OB-BAA-standard-olt-adapter/2.0/yang/bbf-qos-composite-filters.yang imported to sysrepo [ 32%] Generating .bbf-hardware-rpf-dpu-state.installed /home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepotool.sh /home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepoctl --install /home/georgede/rje/netconf-polt-master/third_party/yang-models/OB-BAA-standard-olt-adapter/2.0/yang/bbf-hardware-rpf-dpu-state.yang -a --search-dirs /home/georgede/rje/netconf-polt-master/third_party/yang-models/OB-BAA-standard-olt-adapter/2.0/yang:/home/georgede/rje/netconf-polt-master/third_party/yang-models/IETF_IANA /home/georgede/rje/netconf-polt-master/third_party/yang-models/OB-BAA-standard-olt-adapter/2.0/yang/bbf-hardware-rpf-dpu-state.yang imported to sysrepo [ 33%] Generating .ieee802-dot1x.installed /home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepotool.sh /home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepoctl --install /home/georgede/rje/netconf-polt-master/third_party/yang-models/OB-BAA-standard-olt-adapter/2.0/yang/ieee802-dot1x.yang -a --search-dirs /home/georgede/rje/netconf-polt-master/third_party/yang-models/OB-BAA-standard-olt-adapter/2.0/yang:/home/georgede/rje/netconf-polt-master/third_party/yang-models/IETF_IANA /home/georgede/rje/netconf-polt-master/third_party/yang-models/OB-BAA-standard-olt-adapter/2.0/yang/ieee802-dot1x.yang imported to sysrepo [ 33%] Generating .bbf-alarm-types.installed /home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepotool.sh /home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepoctl --install /home/georgede/rje/netconf-polt-master/third_party/yang-models/OB-BAA-standard-olt-adapter/2.0/yang/bbf-alarm-types.yang -a --search-dirs /home/georgede/rje/netconf-polt-master/third_party/yang-models/OB-BAA-standard-olt-adapter/2.0/yang:/home/georgede/rje/netconf-polt-master/third_party/yang-models/IETF_IANA /home/georgede/rje/netconf-polt-master/third_party/yang-models/OB-BAA-standard-olt-adapter/2.0/yang/bbf-alarm-types.yang imported to sysrepo [ 33%] Generating .bbf-xpon-power-management.installed /home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepotool.sh /home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepoctl --install /home/georgede/rje/netconf-polt-master/third_party/yang-models/OB-BAA-standard-olt-adapter/2.0/yang/bbf-xpon-power-management.yang -a --search-dirs /home/georgede/rje/netconf-polt-master/third_party/yang-models/OB-BAA-standard-olt-adapter/2.0/yang:/home/georgede/rje/netconf-polt-master/third_party/yang-models/IETF_IANA /home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepotool.sh /home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepoctl --change bbf-xpon-power-management -a --enable-feature xpon-power-management /home/georgede/rje/netconf-polt-master/third_party/yang-models/OB-BAA-standard-olt-adapter/2.0/yang/bbf-xpon-power-management.yang imported to sysrepo [ 33%] Generating .bbf-l2-forwarding-shared-fdb.installed /home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepotool.sh /home/georgede/rje/netconf-polt-master/build/fs/bin/sysrepoctl --install /home/georgede/rje/netconf-polt-master/third_party/yang-models/OB-BAA-standard-olt-adapter/2.0/yang/bbf-l2-forwarding-shared-fdb.yang -a --search-dirs /home/georgede/rje/netconf-polt-master/third_party/yang-models/OB-BAA-standard-olt-adapter/2.0/yang:/home/georgede/rje/netconf-polt-master/third_party/yang-models/IETF_IANA [ERR]: Invalid absolute-schema-nodeid nametest "if:interfaces" - prefix "if" not defined in module "bbf-l2-forwarding". sysrepoctl error: Failed to install module "/home/georgede/rje/netconf-polt-master/third_party/yang-models/OB-BAA-standard-olt-adapter/2.0/yang/bbf-l2-forwarding-shared-fdb.yang" (libyang error) For more details you may try to increase the verbosity up to "-v3". third_party/yang-models/CMakeFiles/yang-models-push-scheduled-changes.dir/build.make:1244: recipe for target 'third_party/yang-models/.bbf-l2-forwarding-shared-fdb.installed' failed make[3]: [third_party/yang-models/.bbf-l2-forwarding-shared-fdb.installed] Error 1 CMakeFiles/Makefile2:1879: recipe for target 'third_party/yang-models/CMakeFiles/yang-models-push-scheduled-changes.dir/all' failed make[2]: [third_party/yang-models/CMakeFiles/yang-models-push-scheduled-changes.dir/all] Error 2 Makefile:129: recipe for target 'all' failed make[1]: [all] Error 2 Makefile:137: recipe for target 'host' failed make: [host] Error 2

Br George

igortern commented 2 years ago

Hi George, You need to download from develop branch, not master. Regards, Igor

wdl2015 commented 2 years ago

Hi Igor, thanks a lot for the notes. yeah, with devel branch it can build successfully. Br, George Deng

wdl2015 commented 2 years ago

Hi Igor,

From the commit history the netconf-polt devel branch has changes in recent one month. Could you share your comments whether the devel branch is ready for use? Is it stable enough? Would like to hear your professional advice on this so as to make a decision for upgrading or not. Appreciate much.

Br George Deng

igortern commented 2 years ago

Hi George, BBF uses the same codebase & netopeer2 version for a while now (in obbaa-polt-simulator) and didn't report any problems. BR -Igor

wdl2015 commented 2 years ago

Hi Igor,

Thanks for your comments, this info is helpful to make a decision. I am playing around with netconf-polt devlop branch which has a combination of netopeer2-2.1.16, libnetconf2-2.1.7, libyang-2.0.164, sysrepo-2.1.42. During testing bbf-software-management.yang one libyang-2.0.164 issue is discovered. I wrote a ticket to github libyang team https://github.com/CESNET/libyang/issues/1853 , libyang expert thinks a fix for this issue may be available in libyang develop branch and suggests upgrading to the develop branch. I am not ready to upgrade for now yet. So would like to check with you if you ever saw this issue and have a libyang fix ready.

Br George Deng

igortern commented 2 years ago

Hi George, I didn't encounter the issue. Regards, Igor

On Wed, May 25, 2022 at 10:52 AM dengguochen2003 @.***> wrote:

Hi Igor,

Thanks for your comments, this info is helpful to make a decision. I am playing around with netconf-polt devlop branch which has a combination of netopeer2-2.1.16, libnetconf2-2.1.7, libyang-2.0.164, sysrepo-2.1.42. During testing bbf-software-management.yang one libyang-2.0.164 issue is discovered. I wrote a ticket to github libyang team CESNET/libyang#1853 https://github.com/CESNET/libyang/issues/1853 , libyang expert thinks a fix for this issue may be available in libyang develop branch and suggests upgrading to the develop branch. I am not ready to upgrade for now yet. So would like to check with you if you ever saw this issue and have a libyang fix ready.

Br George Deng

— Reply to this email directly, view it on GitHub https://github.com/balapi/netconf-polt/issues/12#issuecomment-1136573152, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEX4KW637BKNDZ3KYEMJAE3VLV2UDANCNFSM5WOSZD5A . You are receiving this because you commented.Message ID: @.***>

-- This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.