N:1 downstream egress_qos use priority_to_queue mode?

[wdl2015]

Hi Igor,

There is a comment in bbf-xpon-apply-flow-config.c saying N:1 egress_qos will use priority_to_queue mode later. Do you foresee any blocking issue from BAL or QAX SDK to use tm_qmp for N:1 egress_qos?

static bcmos_errno xpon_create_bal_group_member(sr_session_ctx_t srs, const xpon_vlan_subif net_if, const xpon_vlan_subif acc_if, bbf_subif_ingress_rule netif_rule, bbf_subif_ingress_rule acc_rule, uint8_t traffic_class) { const xpon_v_ani_v_enet v_ani_v_enet = (xpon_v_ani_v_enet )acc_if->subif_lower_layer; const xpon_v_ani v_ani = v_ani_v_enet->v_ani; bcmolt_group_members_update op; bcmolt_group_key key = { .id = netif_rule->group_id }; bcmolt_group_member_info memb = {}; bcmolt_group_member_info_list_u8 memb_list = { .len = 1, .arr = &memb }; bcmolt_intf_ref intf_ref = { .intf_type = BCMOLT_INTERFACE_TYPE_PON, .intf_id = v_ani->pon_ni }; / TODO: use tm_qmp mapper derived from qos classifier instead of default / bcmolt_egress_qos egress_qos = { .type = BCMOLT_EGRESS_QOS_TYPE_FIXED_QUEUE,/BCMOLT_EGRESS_QOS_TYPE_PRIORITY_TO_QUEUE,/ .tm_sched.id = xpon_tm_sched_id(BCMOLT_INTERFACE_TYPE_PON, v_ani->pon_ni), .u.fixed_queue = { .queue_id = 0, // .tm_qmp_id = BCM_DEFAULT_TM_QMP_ID, // .tm_q_set_id = BCMOLT_TM_QUEUE_SET_ID_QSET_NOT_USE,

    }
};

Br George Deng

[igortern]

Hi George,

There shouldn't be any impediment using tm_qmp for N:1. Please note that the netconf server in github supports only 1:1. Some N:1 code is present but it is not finished and has never been tested.

Best Regards -Igor

On Thu, Jun 29, 2023 at 7:05 PM dengguochen2003 @.***> wrote:

Hi Igor,

There is a comment in bbf-xpon-apply-flow-config.c saying N:1 egress_qos will use priority_to_queue mode later. Do you foresee any blocking issue from BAL or QAX SDK to use tm_qmp for N:1 egress_qos?

static bcmos_errno xpon_create_bal_group_member(sr_session_ctx_t srs, const xpon_vlan_subif net_if, const xpon_vlan_subif acc_if, bbf_subif_ingress_rule netif_rule, bbf_subif_ingress_rule acc_rule, uint8_t traffic_class) { const xpon_v_ani_v_enet v_ani_v_enet = (xpon_v_ani_v_enet *)acc_if->subif_lower_layer; const xpon_v_ani

v_ani = v_ani_v_enet->v_ani; bcmolt_group_members_update op; bcmolt_group_key key = { .id = netif_rule->group_id }; bcmolt_group_member_info memb = {}; bcmolt_group_member_info_list_u8 memb_list = { .len = 1, .arr = &memb }; bcmolt_intf_ref intf_ref = { .intf_type = BCMOLT_INTERFACE_TYPE_PON, .intf_id = v_ani->pon_ni }; / TODO: use tm_qmp mapper derived from qos classifier instead of default / bcmolt_egress_qos egress_qos = { .type = BCMOLT_EGRESS_QOS_TYPE_FIXED_QUEUE,/ BCMOLT_EGRESS_QOS_TYPE_PRIORITY_TO_QUEUE,*/ .tm_sched.id = xpon_tm_sched_id(BCMOLT_INTERFACE_TYPE_PON, v_ani->pon_ni), .u.fixed_queue = { .queue_id = 0, // .tm_qmp_id = BCM_DEFAULT_TM_QMP_ID, // .tm_q_set_id = BCMOLT_TM_QUEUE_SET_ID_QSET_NOT_USE,

}

};

Br George Deng

— Reply to this email directly, view it on GitHub https://github.com/balapi/netconf-polt/issues/19, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEX4KW7FYIVI6VG7J6C2IOLXNVAOFANCNFSM6AAAAAAZYG6JQE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.

[wdl2015]

Hi Igor,

Glad to know that tm_qmp is good to use. Thanks for letting know the N:1 status. We added some N:1 development by putting the broadcast GEM as member of the N:1 group. That basically works ax expected.. One issue is that the downstream known unicast has problem to find correct GEM port in the one VLAN has multiplbe pbits scenario wich same MAC. BCM suggests to use IWF per_flow_mode to solve this issue. But we see soem concerns like IWF per_flow_mode impacts to QAX QoS, so still doing evaluation. Thanks agagin. Trying out tm_qmp...

Br George Deng

[wdl2015]

Mark this issue as closed.