search

balassy / MMM-Futar

MagicMirror module that displays Budapest public transport information.
MIT License
5 stars 2 forks source link

Request/Improvement Idea: Color icons #3

Closed zttk closed 5 years ago

zttk commented 5 years ago

I was wondering if we could add colored option into the config file. I'm completly new to this project but I may give it a try when I have some free time. I will report back here.

zttk commented 5 years ago

It was really easy, I just updated the MMM-Futar.css file for the MMM-Futar .symbol attribute.

I added color: #3699df; and now my BUS icons are blue.

There are still two portions missing:

balassy commented 5 years ago

@zttk Tamás, it is a great idea, thanks for submitting! Do you want to color only the vehicle icon, right? I'll eventually investigate how could I do that in the most flexible way.

zttk commented 5 years ago

Yes I think it would be great if the icons would be optionally colored. Like in the standard weather forecast app. It is an option in the config file. If I set colored: true the numbers are colored.

I imagined this solution similar, only a simple config line: colored True/false. If colored the BUS would be blue and the TRAM would be yellow. If false everything remains as it is. I don't think the user should specify the colors themself (while this may be feasible, I have my calendar entries colored where I selected the colors myself), you should just go with the standard BKK colors, blue for BUS and yellow for TRAM in my opinion (only the icon).

balassy commented 5 years ago

@zttk Tamás, I'm happy to announce that I just released version 1.2.0 of the MMM-Futar module which displays the symbols and the route text colored by default. You can override the default behavior with the new colorSymbolInHead, coloredTextInHead, coloredSymbolInStopTime configuration flags, and even change the default colors using the symbolColors setting.

I hope you like it!

balassy commented 5 years ago

Released with version 1.2.0: https://github.com/balassy/MMM-Futar/releases/tag/1.2.0