search

balazsbotond / urlcat

A URL builder library for JavaScript.
https://urlcat.org
MIT License
1.82k stars 57 forks source link

query param output bug solved #109

Closed harshilparmar closed 3 years ago

harshilparmar commented 3 years ago

@balazsbotond Bro As we have discussed in #103.

I have checked that when we pass empty pathTemplate it makes wrong format of baseUrl. I have made few changes related to that. Let me know if you have better solution regarding this ✌️ .

balazsbotond commented 3 years ago

Thank you! 👍 I'll have time to review it tomorrow morning.

harshilparmar commented 3 years ago

@balazsbotond I don't know. why this test is failing!!

harshilparmar commented 3 years ago

@balazsbotond I am always happy to help you and learn from you bro.

balazsbotond commented 3 years ago

@all-contributors please add @SeinopSys for review

allcontributors[bot] commented 3 years ago

@balazsbotond

I've put up a pull request to add @SeinopSys! :tada: