search

balazsbotond / urlcat

A URL builder library for JavaScript.
https://urlcat.org
MIT License
1.82k stars 57 forks source link

2.x #115

Closed harshilparmar closed 3 years ago

harshilparmar commented 3 years ago

@balazsbotond As we have discussed here https://github.com/balazsbotond/urlcat/issues/103#issuecomment-743245525

I have changed 2.x 🎉

I just merged queryParamsBug.Correct me If I am wrong !!

balazsbotond commented 3 years ago

Looks like you merged everything from master to 2.x which defeats the purpose of a separate 2.x branch (which is to be able to continue supporting the current published latest version while working on the next one).

What you need to do is to reimplement the fix on top of the 2.x branch (or cherry-pick your commit but it may not work out well because the branches have diverged considerably).

balazsbotond commented 3 years ago

I'm closing this PR because you will need to open a new one.