Closed harshilparmar closed 4 years ago
Thanks! I will have time to review this later today.
@balazsbotond Done brother!! and One last question
it('Can\'t handle blank string as param', () => {
expect(() => urlcat('http://example.com/path/:p', { p: " " }))
.to.throw(TypeError, "Path parameter p cannot be of type string. Allowed types are: boolean, string, number.");
});
this will show, above error while passing blank string as param,what do you think? is this ok ? or we have to the change specific like cannot be type blank string
?
@balazsbotond Done brother!! and One last question
it('Can\'t handle blank string as param', () => { expect(() => urlcat('http://example.com/path/:p', { p: " " })) .to.throw(TypeError, "Path parameter p cannot be of type string. Allowed types are: boolean, string, number."); });
this will show, above error while passing blank string as param,what do you think? is this ok ? or we have to the change specific like
cannot be type blank string
?
I think the error message in this case should be Path parameter ${key} cannot be an empty string.
@balazsbotond Done brother!! and One last question
it('Can\'t handle blank string as param', () => { expect(() => urlcat('http://example.com/path/:p', { p: " " })) .to.throw(TypeError, "Path parameter p cannot be of type string. Allowed types are: boolean, string, number."); });
this will show, above error while passing blank string as param,what do you think? is this ok ? or we have to the change specific like
cannot be type blank string
?I think the error message in this case should be
Path parameter ${key} cannot be an empty string.
But for this We have to make separate error message !! Is this viable ??
But for this We have to make separate error message !! Is this viable ??
Yes, this needs a separate if statement and error message.
But for this We have to make separate error message !! Is this viable ??
Yes, this needs a separate if statement and error message.
@balazsbotond ohh, thanks for solving doubt.I will to that.
Glad I could help :)
@balazsbotond it's done!!
Great, thank you! ๐ I will have time to review it tomorrow morning.
Everything looks good to me now. Thank you for your work on this issue. ๐
Everything looks good to me now. Thank you for your work on this issue. ๐
it's my pleasure ๐ฏ
Summary
13 is solved!! Please let me know,if there any changes to done.Also trimmed value to check missing value.