balazsbotond / urlcat

A URL builder library for JavaScript.
https://urlcat.org
MIT License
1.82k stars 57 forks source link

Corrects the problem with coverage by adding jest #44

Closed tiago154 closed 3 years ago

tiago154 commented 3 years ago

Summary

This PR switching the runner test to Jest to fix the coverage problem reported here #39

Details

Jest has in a single framework the execution of tests, generation of coverage, expects and mocks.

So this is a suggestion to correct the problem. I also validated the integration with coveralls, where everything seems to be OK.

Any problem let me know.

Example:

image

Viewing coverage in html:

image

balazsbotond commented 3 years ago

This is awesome! Thank you. Merging 👍

balazsbotond commented 3 years ago

@all-contributors please add @tiago154 for code

allcontributors[bot] commented 3 years ago

@balazsbotond

I've put up a pull request to add @tiago154! :tada:

balazsbotond commented 3 years ago

I had to fix a small problem that occured on my Windows machine (jest was trying to run .d.ts files), but now it works beautifully:

https://coveralls.io/github/balazsbotond/urlcat?branch=master

Thanks again!