Deno CI in Travis - Githubissues

tcarrio commented 4 years ago

Summary

As suggested in issue #43 , it would be nice to have some kind of automation around the Deno runtime remaining compatible with this library. I have some experience with CI tooling and figured I could help extend the current Travis config.

Details

Providing build matrix to support multilanguage builds in Travis
Since no official Docker images exist for Deno yet, using the popular images provided by github.com/hayd/deno-docker
Custom Dockerfile providing deno runtime with the full project
New pipeline commands using native deno functionality which:
- run src/index.ts
- bundle src/index.ts
- lint src/index.ts
Note: No test commands as Deno has its own test framework that would have to replace the existing Jest tests

This provides minimal updates around linting errors (implemented one of the type checking functions using TypeScript type guard syntax and disabled an any linting error) as well.

tcarrio commented 4 years ago

I updated it to follow a similar design to your current Node.js commands and also remove containers after the run completes by default.

tcarrio commented 4 years ago

Caught one last time by trailing whitespace. The touch-ups should be complete now- sorry for the noise.

tcarrio commented 4 years ago

This was rebased on master. There appears to be an import from qs now, I wonder if that will break our Deno compatibility here.

tcarrio commented 4 years ago

As somewhat expected, external libraries breaks the Deno compatibility without some considerable effort. It appears the latest merge from #51 to resolve #6.

balazsbotond commented 4 years ago

Sorry about that; I didn't realize it would break Deno compatibility. I've created a new branch 2.x from the commit before #51 was merged - could you please retarget your PR on it so I can merge it? After that, I will deal with the qs dependency. Sorry about the inconvenience.

tcarrio commented 4 years ago

Thanks for branching that out! I'm rebasing the work on the new 2.x branch. Should be up shortly :+1:

tcarrio commented 4 years ago

I opened #57 which is based on the 2.x branch

balazsbotond commented 4 years ago

Thank you! Closing this one because I've just merged #57

balazsbotond / urlcat

Deno CI in Travis #50

Summary

Details