feat: Support array and object query parameters and formatting - #6

balazsbotond / urlcat

A URL builder library for JavaScript.

https://urlcat.org

MIT License

1.82k stars 57 forks source link

Closed SimonJang closed 3 years ago

SimonJang commented 3 years ago

PR follow up from the discussion we had in #6

Added qs as dependency
Create configure factory function that returns a decorator function wrapping urlcat
Prevented breaking changes by using RFC1738 space parsing for query parameters
Add type for the configuration object
Update/added documentation
Added tests to validate

balazsbotond commented 3 years ago

Very solid PR - thank you! All changes merged 🎉

I took the liberty of fixing some minor linting and code coverage problems to make the build pass. I hope you don't mind :)

kaiyuandeng commented 3 years ago

hi @SimonJang or @balazsbotond , was this change published? I see the version remains 2.0.4 and I am not picking up the changes when I upgrade.

balazsbotond commented 1 year ago

@kaiyuandeng and everyone else: I'm sorry it took so long but I have finally released the new version.