search

balazsbotond / urlcat

A URL builder library for JavaScript.
https://urlcat.org
MIT License
1.82k stars 57 forks source link

Use eslint instead of tslint #54

Closed balazsbotond closed 3 years ago

balazsbotond commented 3 years ago

We currently use tslint for linting but as it turns out, it is deprecated in favor of eslint.

We need to switch to eslint with a minimal config we can extend later.

Resources:

drishit96 commented 3 years ago

Hi @balazsbotond, I would like to work on this issue

balazsbotond commented 3 years ago

@drishit96 it's yours! :)

drishit96 commented 3 years ago

I am almost done with the eslint migration, except for this one issue. ParamMap defined here, has any used in it and eslint is giving a warning for the same. I tried changing it to string and the tests were passing locally, but then the tests failed in travis ci because number was being used in the test. Any help?

balazsbotond commented 3 years ago

Please disable the warning for that line - we will specify the type more accurately later but this will be OK for now.

drishit96 commented 3 years ago

I have disabled the warning for that line. Let me know if any other change is needed in the PR.