search

balazsbotond / urlcat

A URL builder library for JavaScript.
https://urlcat.org
MIT License
1.82k stars 57 forks source link

Update README to reflect changes in v3 #56

Closed tcarrio closed 1 year ago

tcarrio commented 3 years ago

Describe the bug The README notes several key features to the project. From the README:

Features:

Friendly API
No dependencies
0.8 KB minified and gzipped
TypeScript types provided

The second and third bullets are no longer correct.

To Reproduce Steps to reproduce the behavior:

  1. Go to README
  2. Scroll down to 'Features'
  3. See error

Expected behavior The updated information on key features with the latest in master.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context This should be updated to the correct minified size and no longer include a mention of zero dependencies.

tcarrio commented 3 years ago

Hoping we can figure out a way to get around these issues to continue supporting Deno. While qs might be an easier way for the package to support query parameters, it could be difficult to require dependencies and support Deno. We'll probably have to hold further discussion here or open another issue to track it.

balazsbotond commented 3 years ago

I think we should keep this issue as a reminder to update the README before releasing the next major version.

I've just opened a new issue to discuss Deno support: #74

balazsbotond commented 1 year ago

Fixed in https://github.com/balazsbotond/urlcat/pull/190