search

balazsbotond / urlcat

A URL builder library for JavaScript.
https://urlcat.org
MIT License
1.82k stars 57 forks source link

Update Readme.md and contribute.md #64

Closed sakshi2912 closed 3 years ago

sakshi2912 commented 3 years ago

Summary

The repeated section of "contribute" has been removed from README.md, as it is already a part of CONTRIBUTE.md. Shifted the "contributers" section to CONTRIBUTE.md.

Details

balazsbotond commented 3 years ago

Thanks for your PR but would you please fill out the PR template and explain why you made these changes?

bmnidhin commented 3 years ago

Probably a spam.

@sakshi2912 Just moved contents from README.md to CONTRIBUTING.md

bmnidhin commented 3 years ago

Probably a spam.

@sakshi2912 Just moved contents from README.md to CONTRIBUTING.md

@balazsbotond

sakshi2912 commented 3 years ago

Probably a spam.

@sakshi2912 Just moved contents from README.md to CONTRIBUTING.md

It was in one of the open issues.

sakshi2912 commented 3 years ago

Probably a spam. @sakshi2912 Just moved contents from README.md to CONTRIBUTING.md

It was in one of the open issues.

63

balazsbotond commented 3 years ago

@sakshi2912 I see. The documentation is on the gh-pages branch. Could you please create a new PR against that branch? This wasn't described in the issue you referenced so you couldn't have known.

A piece of advice: it is considered good form to write a description for the PRs you open, however trivial, and reference any relevant issues. This way misunderstandings like what happened here can be prevented.

Thanks again for your interest in the project and feel free to ask any further questions you have here in the comments.

sakshi2912 commented 3 years ago

@sakshi2912 I see. The documentation is on the gh-pages branch. Could you please create a new PR against that branch? This wasn't described in the issue you referenced so you couldn't have known.

A piece of advice: it is considered good form to write a description for the PRs you open, however trivial, and reference any relevant issues. This way misunderstandings like what happened here can be prevented.

Thanks again for your interest in the project and feel free to ask any further questions you have here in the comment.

Sure, will do that.