balbasty / nitorch

Neuroimaging in PyTorch
Other
83 stars 14 forks source link

Add nitorch package data #25

Closed brudfors closed 3 years ago

brudfors commented 3 years ago

24

brudfors commented 3 years ago

@balbasty, I did it not the way you wanted... Seems as if people do not like downloading during package install:

https://stackoverflow.com/questions/37513279/using-setuptools-how-can-i-download-external-data-upon-installation

I put it in core.utils for now. Also, there is probably a neater way of getting the data directory, which will not break if we change the package structure.

balbasty commented 3 years ago

Ok that's fine! Can you just move your utilities to pyutils? Utils is for torch utilities (the name is not very clear...)

balbasty commented 3 years ago

Also add the dependency to wget in setup.py (install_requires=[...])

brudfors commented 3 years ago

Done.

brudfors commented 3 years ago

Thanks :)

Yes, good idea :+1: