search

balbasty / nitorch

Neuroimaging in PyTorch
Other
83 stars 14 forks source link

Set nibabel version #74

Closed brudfors closed 1 year ago

brudfors commented 1 year ago

It seems as nitorch.io errors when using the latest version of nibabel as its backend:

AttributeError: type object 'ArrayProxy' has no attribute 'order'

Setting the nibabel version that nitorch uses to an older one seems to fix the problem.

@balbasty, have I changed the nibabel version in all places needed?

balbasty commented 1 year ago

Hi @brudfors,

Do you know with which version starts the issue? Any chance we can have a less stringent condition, like "nibabel <= 4" or something?

I think I fixed that bug in a more general way in the infamous monster branch that I have to merge. I'll have to remember to remove this condition once it's merged.

Thank Yael

brudfors commented 1 year ago

It works on v4.0.2, not more recent ones. Should I change to nibabel<=4 then?

balbasty commented 1 year ago

Looks like they went straight from 4.0 to 5.0, so yeah <= 4 would work, thanks!

brudfors commented 1 year ago

Great, @balbasty please merge if you think looks OK.