balbuze / volumio-plugins

volumio's plugins from balbuze
190 stars 60 forks source link

[volspotconnect2] librespot crashing with invalid enum value #133

Closed cortegedusage closed 6 years ago

cortegedusage commented 6 years ago

Hey Balbuze,

after my android spotify app updated i cannot connect to librespot anymore running it from cli gives me thread 'main' panicked at 'called Result::unwrap() on an Err value: WireError(InvalidEnumValue(13))', /checkout/src/libcore/result.rs:906:4

might be related to https://github.com/librespot-org/librespot/pull/167

I noticed you changed the binairy did pulled the code from github or did you just recompiled it with the new desired port nr?

cheers Dennis

balbuze commented 6 years ago

Hi, This is the same librespot than previous version. Just a change for the port. Do you use x86 or arm?

cortegedusage commented 6 years ago

I use arm, but i'm afraid you will have to compile again against the new code from librespot-org.

Spotify has added a new enum value (whatever that may be) and it causes librespot to crash. I tested it with updated android app and it crashed, but with the outdated ios app from my wife it works flawless.

it looks like these issues : librespot-org/librespot#167 https://github.com/librespot-org/librespot/issues/172

cheers

ashthespy commented 6 years ago

@cortegedusage I built a version with the patches merged - would you be willing to test?

cortegedusage commented 6 years ago

Yeah sure, where van i find IT?

Op 28 feb. 2018 10:11 a.m. schreef "Ash" notifications@github.com:

@cortegedusage https://github.com/cortegedusage I built a version with the patches merged - would you be willing to test?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/balbuze/volumio-plugins/issues/133#issuecomment-369169710, or mute the thread https://github.com/notifications/unsubscribe-auth/AV69TSyNv-stUgOX7Dw15riZZbWGseCfks5tZRhVgaJpZM4SVsJy .

balbuze commented 6 years ago

@ash have you changed the port for the socket ? I set 5030.

ashthespy commented 6 years ago

Sorry - work called :-) If you have an arm device try with this!

wget https://git.io/vAXK0 -O volspotconnect2.zip
mkdir ./volspotconnect2 
miniunzip volspotconnect2.zip -d ./volspotconnect2
cd ./volspotconnect2
volumio plugin install
cortegedusage commented 6 years ago

@ash

hmm still same error occurs.

2018-02-28 16:17 GMT+01:00 Ash notifications@github.com:

Sorry - work called :-) If you have an arm device try with this!

wget https://git.io/vAXK0 -O volspotconnect2.zip unzip volspotconnect2.zip -d volspotconnect2 cd ./volspotconnect2 volumio plugin install

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/balbuze/volumio-plugins/issues/133#issuecomment-369270515, or mute the thread https://github.com/notifications/unsubscribe-auth/AV69TXK2EAsxGbz7MMkqX2skwcAsKSTUks5tZW1BgaJpZM4SVsJy .

balbuze commented 6 years ago

using previous cmd still download the same librespot. I have to compile and upload a new version before use.

cortegedusage commented 6 years ago

Ah that explains

Op 28 feb. 2018 6:19 p.m. schreef "balbuze" notifications@github.com:

using previous cmd still download the same librespot. I have to compile and upload a new version before use.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/balbuze/volumio-plugins/issues/133#issuecomment-369312468, or mute the thread https://github.com/notifications/unsubscribe-auth/AV69TZPb0WubFS6cx2wCbk3Ed0WcBPENks5tZYnlgaJpZM4SVsJy .

ashthespy commented 6 years ago

Ah - this new plugin system - it still uses the install.sh file? Here is the new binary file

cd /data/plugins/music_service/volspotconnect2/
wget https://git.io/vA1f1 -O librespot.zip
miniunzip librespot.zip
chmod +x librespot 
rm librespot.zip
balbuze commented 6 years ago

sure it is the same. But it downloads wget https://github.com/balbuze/volumio-plugins/raw/master/plugins/music_service/volspotconnect2/arch/armhf/librespot-armhf5030.tar.xz at install time. So I'm going to upload your version of librespot

cortegedusage commented 6 years ago

new binary works!

thank you guys!

2018-02-28 18:45 GMT+01:00 balbuze notifications@github.com:

sure it is the same. But it downloads wget https://github.com/balbuze/ volumio-plugins/raw/master/plugins/music_service/ volspotconnect2/arch/armhf/librespot-armhf5030.tar.xz at install time. So I'm going to upload your version of librespot

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/balbuze/volumio-plugins/issues/133#issuecomment-369320535, or mute the thread https://github.com/notifications/unsubscribe-auth/AV69TfHg7ez6j4d7EmQPT_s554PwmYe9ks5tZY_lgaJpZM4SVsJy .

krisss85 commented 6 years ago

Yay it works. Thx for fixing this.

WalterBorgstein commented 6 years ago

Does this have an impact on the working via the IOS app of Spotify? Since a couple of days connect stopped working for me.

ashthespy commented 6 years ago

Yep - it should fix that.

WalterBorgstein commented 6 years ago

Great! I will wait for the plugin update ;)

ashthespy commented 6 years ago

Dunno how long until it's pushed to the official plugin manager - but until then can get it with

wget https://github.com/balbuze/volumio-plugins/raw/master/plugins/music_service/volspotconnect2/volspotconnect2.zip
mkdir ./volspotconnect2
miniunzip volspotconnect2.zip -d ./volspotconnect2
cd ./volspotconnect2
volumio plugin refresh
balbuze commented 6 years ago

If no problem, I'll push to volumio saturday. But don't know when itwill be available in volumio!

messismore commented 6 years ago

Do plugins installed via the manager update automatically?

balbuze commented 6 years ago

You can install it "by hand" f you can't wait.... I just send a PR to volumio in order to update the official plugin. But can't tell you when it will be updated

messismore commented 6 years ago

Waiting is no problem 😄 I was just wondering whether there is something I have to do when the update becomes available in the manager.

balbuze commented 6 years ago

When the update will be available, you'll see an "update" button in the plugin list. But it will not be updated automatically.

Levdbas commented 6 years ago

Ey there, after manually updating to 0.6.2 I still run into errors.

Mar 03 12:49:45 volumio volumio[13577]: INFO:librespot_core::session: Connecting to AP "gew1-accesspoint-b-r4r7.ap.spotify.com:4070" Mar 03 12:49:51 volumio volumio[13577]: INFO:librespot_core::session: Authenticated as "levdbas" ! Mar 03 12:49:51 volumio volumio[13577]: INFO:librespot_core::session: Country: "NL" Mar 03 12:49:51 volumio volumio[13577]: INFO:librespot::audio_backend::alsa: Using alsa sink Mar 03 12:49:51 volumio volumio[13577]: thread 'main' panicked at 'calledResult::unwrap()on anErrvalue: WireError(InvalidEnumValue(13))', /checkout/src/libcore/result.rs:906:4 Mar 03 12:49:51 volumio volumio[13577]: note: Run withRUST_BACKTRACE=1for a backtrace. Mar 03 12:49:51 volumio systemd[1]: volspotconnect2.service: main process exited, code=exited, status=101/n/a Mar 03 12:49:51 volumio systemd[1]: Unit volspotconnect2.service entered failed state. Mar 03 12:49:53 volumio systemd[1]: volspotconnect2.service holdoff time over, scheduling restart. Mar 03 12:49:53 volumio systemd[1]: Stopping Volspotconnect2 Daemon... Mar 03 12:49:53 volumio systemd[1]: Starting Volspotconnect2 Daemon... Mar 03 12:49:53 volumio systemd[1]: Started Volspotconnect2 Daemon. Mar 03 12:49:53 volumio volumio[13671]: INFO:librespot: librespot d9deef8 (2018-02-06). Built on 2018-02-06. Build ID: BKb2hWLu Mar 03 12:49:53 volumio volumio[13671]: WARN:mdns: Failed to register IPv6 receiver: Error { repr: Os { code: 19, message: "No such device" } }

balbuze commented 6 years ago

how did you install ? you are still using a old version of librespot : librespot d9deef8 (2018-02-06). Built on 2018-02-06. Build ID should be INFO:librespot: librespot c1128f9 (2018-02-28). Built on 2018-02-28. Build ID: B698bwAU please remove previous version and install the new using ssh (waiting the official)

Levdbas commented 6 years ago

Removing the plugin entirely before installing it again via SSH did the trick. Thanks!

cortegedusage commented 6 years ago

Original problem resolved

closing