search

balbuze / volumio-plugins

volumio's plugins from balbuze
190 stars 60 forks source link

[Volspotconnect2] Update `vollibrespot` to `0.1.8` #247

Closed ashthespy closed 5 years ago

ashthespy commented 5 years ago

Notable changes:

Closes #238

balbuze commented 5 years ago

Hi ash! Thanks for the Pr. There is something that needs to be fixed (not related to the update). When the plugin is disabled, it remains in memory and still send message such when the output is changed in Volumio. Something like a socket.off seems to be required. Any idea?

ashthespy commented 5 years ago

Do you mean when the ALSA output device is changed? I don't completely follow..

balbuze commented 5 years ago

Yes. Step to reproduce. Use the plugin, disable it and change output device in playback option of Volumio. Save. You'll see the plugin update message for the outout. I fixed a similar behaviour in an other plugin using socket.io by adding a socket.off in the 'onstop' section.

ashthespy commented 5 years ago

Yes. Step to reproduce. Use the plugin, disable it and change output device in playback option of Volumio. Save. You'll see the plugin update message for the outout. I fixed a similar behaviour in an other plugin using socket.io by adding a socket.off in the 'onstop' section.

That sounds like a Volumio bug right? When you disable the plugin, it should also drop all listeners, either way I will take a look when I have time!

ashthespy commented 5 years ago

Opened up a new issue https://github.com/volumio/Volumio2/issues/1836 socket.off wont work in our case, as we don't use the websocket client, but hook directly in with commandRouter.sharedVars.registerCallback. The pluginmanager ofcourse just calls the onStop method and moves on, so we need to disable these callbacks manually.

balbuze commented 5 years ago

It can't connect when shared device is activated. It even dosen't appears as a device in Spotify

ashthespy commented 5 years ago

@balbuze Could you check if its broadcasting the mDNS service? I was having issues with my desktop client a while ago, while the Andorid app was working fine..

balbuze commented 5 years ago

I can't check now, but it was non ok from my smartphone Android and from my laptop Ubuntu.

balbuze commented 5 years ago

when multi user disabled : Nov 08 19:40:44 volumio-rpi4 sudo[4767]: volumio : TTY=unknown ; PWD=/ ; USER=root ; COMMAND=/sbin/ifconfig wlan0 Nov 08 19:40:44 volumio-rpi4 volumio[4763]: vollibrespot v0.1.8 0b7ed39 2019-11-06 (librespot f67905a 2019-11-05) -- Built On 2019-11-06 Nov 08 19:40:44 volumio-rpi4 sudo[4767]: pam_unix(sudo:session): session opened for user root by (uid=0) Nov 08 19:40:44 volumio-rpi4 volumio[1337]: [SpotifyConnect] null Nov 08 19:40:44 volumio-rpi4 sudo[4767]: pam_unix(sudo:session): session closed for user root Nov 08 19:40:44 volumio-rpi4 volumio[1337]: info: Setting screensaver timeout to 120 seconds. Nov 08 19:40:44 volumio-rpi4 volumio[4763]: [Vollibrespot] librespot_connect::discovery: Zeroconf server listening on 0.0.0.0:41245 Nov 08 19:40:44 volumio-rpi4 volumio[4763]: [Vollibrespot] : Failed to register IPv6 receiver: Os { code: 19, kind: Other, message: "No such device" } Nov 08 19:40:44 volumio-rpi4 sudo[4781]: volumio : TTY=unknown ; PWD=/ ; USER=root ; COMMAND=/bin/systemctl start volspotconnect2.service Nov 08 19:40:44 volumio-rpi4 sudo[4781]: pam_unix(sudo:session): session opened for user root by (uid=0) Nov 08 19:40:44 volumio-rpi4 systemd[1]: Started Volspotconnect2 Daemon. Nov 08 19:40:44 volumio-rpi4 sudo[4781]: pam_unix(sudo:session): session closed for user root Nov 08 19:40:44 volumio-rpi4 volumio[1337]: [SpotifyConnect] Vollibrespot Daemon Started Nov 08 19:40:44 volumio-rpi4 wpa_supplicant[1043]: wlan0: Failed to initiate sched scan Nov 08 19:40:45 volumio-rpi4 volumio[1337]: [SpotifyConnect] Internal Server Error

ashthespy commented 5 years ago

I will take a look, I have an idea - don't release yet!

balbuze commented 5 years ago

:+1: