balbuze / volumio-plugins

volumio's plugins from balbuze
190 stars 60 forks source link

Volspotconnect2 - Player stops when finding an unplayable song #266

Closed pachulo closed 4 years ago

pachulo commented 4 years ago

I think this was not happening before the update to 1.0.x, but anyway: I just found out that when connected to Volumio, if I “SHUFFLE PLAY“ a playlist that contains unplayable songs some of those might get queued and, as soon as Volumio tries to reproduce one, instead of skipping it, stops playing.

I don't really know where the problem is, because when I'm listening on in my phone I never get unplayable songs queued...I guess because the “Show unplayable songs” setting is disabled, but I thought that it will also apply to Volumio Spotify Connect plugin...

ashthespy commented 4 years ago

Could you share such a playlist?

pachulo commented 4 years ago

Yeah, sorry; here's one example:

pachulo commented 4 years ago

were you able to reproduce this @ashthespy ? Thanks!

ashthespy commented 4 years ago

@pachulo sorry, this slipped under my radar, will try looking at it over the weekend!

EDIT: Had a quick look, looks like with the new gapless playback changes, unplayable tracks are just stopped, instead of skipped.

[Vollibrespot] : Event: PlaybackLoading { track_id: SpotifyId { id: 221688197964708279733893794639650733090, audio_type: Track } }
[Vollibrespot] : Loading <Dancing With Myself - 2001 Digital Remaster> with Spotify URI <spotify:track:54HWkXBa3O7jH4vletYhc6>
[Vollibrespot] : <spotify:track:54HWkXBa3O7jH4vletYhc6> is not available
[Vollibrespot] : The player has stopped unexpectedly.

Fixed it upstream, will add it into the next build :-)

ashthespy commented 4 years ago

@pachulo Fixed in Vollibrespot v0.2.1

pachulo commented 4 years ago

Out of curiosity: when will this show up @ashthespy ?

Thanks!

ashthespy commented 4 years ago

You can already install it via ssh from this repository, not sure when it will be made available in the plugin repo..

ashthespy commented 4 years ago

Just noticed @balbuze merged v1.0.3 to the official plugin repo as well..

pachulo commented 4 years ago

Tested and working! Thanks a lot!