balbuze / volumio-plugins

volumio's plugins from balbuze
190 stars 60 forks source link

Stop, play, track changes causes clicking sound #303

Open seppo498573908457 opened 3 years ago

seppo498573908457 commented 3 years ago

Those commands seem to be instantaneous, which causes a clicking or thumbing sound each time. Thats normal, but proper implementation would employ a really quick fade in, out and/or cross fade.

Tested on miniDSP SHD Volumio, plugin version 1.0.5 (7-10-2020). OS info

balbuze commented 3 years ago

??? Sorry but I can't understand... What is the plugin and commands you are talking about? This version of volumio is proper to MiniDsp...

seppo498573908457 commented 3 years ago

I got the miniDSP SHD and use Spotify Connect (Spotify on tablet, output from minidsp device) with it, so it's this plugin is in use, right?

Whenever I use my tablet and seek within track, start, stop and change track, I get a faint click from my speakers. If you stop playback abruptly in middle of a wave, it will generate square wave edge to 0, right? If you play square wave edge like that from speakers, it's a click or thumb if a low-pass filter is in place.

I would suggest using a quick fade (~100ms) always when starting or stopping playback in middle of a song. If you can affect that, that is.