search

balchua / microk8s-actions

Bootstrap MicroK8s with Github Actions
34 stars 9 forks source link

Enable storage add-on #3

Closed camille-rodriguez closed 3 years ago

camille-rodriguez commented 3 years ago

Hi @balchua ,

I am using this action in one of my workflows and I need to enable the storage add-on, so here is a PR to include it in your action.

The only thing I am unsure of, is how to test it in the workflow with this updated version, rather than the default "balchua/microk8s-actions@release/v0.1" (since e2e.yaml refers to the latest build). Should we update the e2e.yaml to refer to a build of this action including changes?

Cheers, Camille

camille-rodriguez commented 3 years ago

Results of the test are here : https://github.com/camille-rodriguez/microk8s-actions/actions/runs/261208610

balchua commented 3 years ago

Hi @camille-rodriguez Thank you for this pr. 👍 Oh yes the e2e.yaml is pointing to a tag. Sorry bout that.

balchua commented 3 years ago

I'll get the e2e fix soon.

camille-rodriguez commented 3 years ago

Great, thank you!

balchua commented 3 years ago

@camille-rodriguez i have released 0.1.3 to include your changes. updated the e2e.yaml to refer to the master branch.

Thank you again for including the addon.

camille-rodriguez commented 3 years ago

Awesome, thank you for the update @balchua . I realized I will need the rbac add-on as well, so you can expect another PR from me shortly! :)

balchua commented 3 years ago

Rbac is already available.

camille-rodriguez commented 3 years ago

Ah you're right, nevermind.