search

balderdashy / angularSails

AngularJS bindings for Sails. http://angularjs.org
MIT License
184 stars 36 forks source link

Incompatibility with stable (0.10.5) version of sails? #46

Closed devjones closed 9 years ago

devjones commented 9 years ago

angularSails is using the latest version of sails.io.js, which is currently 0.11.4. From my testing it seems this version may not be backwards compatible with the stable version of the sails (v 0.10.5).

I get CORS error from socket.io when using v0.11.4 sails.io.js with v0.10.5 sails server. This despite the fact I've allowed all CORS options.

I had to force angularSails to use v0.10.3 of sails.io.js to get everything working since I'm on v0.10.5 of the sails server.

See commit here: https://github.com/devjones/angularSails/commit/556322645c2175a507fb9c089b765a0879f182e0

robwormald commented 9 years ago

Theoretically angularSails should just use whatever version of sails.io you include. I haven't had a chance to actually test yet, but I'll try to have a look tomorrow (Christmas Eve)

Cheers

Rob

Sent from my iPhone

On Dec 23, 2014, at 8:08 PM, devjones notifications@github.com wrote:

angularSails is using the latest version of sails.io.js, which is currently 0.11.4. From my testing it seems this version may not be backwards compatible with the stable version of the sails (v 0.10.5).

I get CORS error from socket.io when using v0.11.4 sails.io.js with v0.10.5 sails server. This despite the fact I've allowed all CORS options.

I had to force angularSails to use v0.10.3 of sails.io.js to get everything working since I'm on v0.10.5 of the sails server.

See commit here: devjones@5563226

— Reply to this email directly or view it on GitHub.

robwormald commented 9 years ago

Read this properly now. I'll cut a final 0.10x version and then a new 0.11x which should be independent of sails.io. Thanks.