search

balderdashy / mast

UI conventions built on top of Backbone.JS
MIT License
81 stars 14 forks source link

2.x: beforeClose not called on child regions #104

Closed Zolmeister closed 11 years ago

Zolmeister commented 11 years ago

The beforeClose event is not being called on nested regions.

mikermcneil commented 11 years ago

Thanks for reporting

Mike's phone

On Jun 25, 2013, at 12:54, Zoli Kahan notifications@github.com wrote:

The beforeClose event is not being called on nested regions.

— Reply to this email directly or view it on GitHub.

mikermcneil commented 11 years ago

I believe this is fixed now if anyone has a sec to test

ghernandez345 commented 11 years ago

This works now. Just need to make sure we document that before close requires a callback argument that is called at the end.

mikermcneil commented 11 years ago

Def

Mike's phone

On Aug 28, 2013, at 12:25, Gabe Hernandez notifications@github.com wrote:

This works now. Just need to make sure we document that before close requires a callback argument that is called at the end.

— Reply to this email directly or view it on GitHub.