search

balderdashy / mast

UI conventions built on top of Backbone.JS
MIT License
81 stars 14 forks source link

region.remove(0) doesn't work #135

Closed mikermcneil closed 10 years ago

mikermcneil commented 10 years ago

Can't remove a child component/template from a region if that child template has an index of 0-- i.e.

// in a component somewhere:
this.myRegion.remove(0); // doesn't work
this.myRegion.remove(4); // works fine

Probably just a == that needs to be an === or a ! that needs to be a typeof x==='undefined'

mikermcneil commented 10 years ago

Actually calls to remove() with other indices are also failing

mikermcneil commented 10 years ago

Actually not 100% sure this is true-- will double-check.

mikermcneil commented 10 years ago

Doh nevermind it's golden. Sorry!