search

balderdashy / sails.io.js

Browser SDK for communicating w/ Sails via sockets
https://sailsjs.com/documentation/reference/web-sockets/socket-client
183 stars 118 forks source link

Add rejectUnauthorized to the settable options for socket connections. #103

Closed ksylvan closed 8 years ago

ksylvan commented 8 years ago

This fixes https://github.com/balderdashy/sails.io.js/issues/102

kapouer commented 8 years ago

Not that i directly care, but to get that PR accepted you should restrict the commit to only what you propose to do. No whitespaces fixing, no reordering of SOCKET_OPTIONS.

ksylvan commented 8 years ago

Did that. CI checks are failing, though it works well in my environment.

ksylvan commented 8 years ago

Original poster of https://github.com/balderdashy/sails.io.js/issues/102 verified that his problem is fixed by this PR.

mrvini commented 8 years ago

@ksylvan , any updates on this merge request? are tests failing because new option missing from https://github.com/balderdashy/sails.io.js/blob/master/test/helpers/lifecycle.js#L103

ksylvan commented 8 years ago

No updates. Tests are failing because of something unrelated. Looks like that test has been failing on node-0.10 for a few previous commits too.

sgress454 commented 8 years ago

I can ignore the test failure; as seems to happen with Travis, an older version of Node just started failing one day after an unrelated commit. It passes for me locally with v0.10.x.

I'd love for there to be a test that actually demonstrates the problem that this solves, but setting up SSL tests is a bigger job that we should be undertaking separately anyway. And, adding an allowable option to the SOCKET_OPTIONS array is not exactly a dangerous proposition, so I'll take y'alls word for it.

ksylvan commented 8 years ago

Thanks. When is the next release of sails.io.js that will include this?

ksylvan commented 8 years ago

@sgress454 Thanks for merging this. When is the next scheduled release of sails.io.js for npm?

sgress454 commented 8 years ago

@ksylvan Just published 0.13.8!

ksylvan commented 8 years ago

@sgress454 Thank you very much!