Sails hook grunt need to update dependencies grunt-sync

erwinsetiawan commented 6 years ago

Sails version: 1.0.2 Node version: 10.5.0 NPM version: 6.1.0 DB adapter name: N/A DB adapter version: N/A Operating system: Mac OS

I face problem on grunt task and it only happen on newest nodejs version 10.5.0 and no faced any issue on node 10.4.1 or previous version

Running "watch" task
Waiting...
>> File "assets/styles/project/_colors.scss" changed.
Running "less:dev" (less) task
>> 1 stylesheet created.

Running "sass:dev" (sass) task

Running "sync:dev" (sync) task
Warning: Cannot read property 'bigint' of undefined Use --force to continue.

Some guy from grunt told me that it already fixed on grunt-sync 0.8.0 but on sails-hook-grunt dependencies still using grunt-sync 0.6.2, so i can't update this dependencies.

So I think need to try upgrade dependencies for sails-hook-grunt.

Thank You

sailsbot commented 6 years ago

@erwinsetiawan Thanks for posting, we'll take a look as soon as possible.

For help with questions about Sails, click here. If you’re interested in hiring @sailsbot and her minions in Austin, click here.

andremaha commented 6 years ago

Please fix this - getting kind of hard to sails lift every time I change anything...

raqem commented 6 years ago

@erwinsetiawan and @andremaha It is possible to customize your grunt version in Sails V1. You have to go to the tasks folder then open config then open one of the files and it gives you directions on how to go about changing it in 2 steps.

Here's how:
Install it as a local dependency of your Sails app:
$ npm install grunt-hash --save-dev --save-exact
Then uncomment the following code:
 Load Grunt plugin from the node_modules/ folder.
grunt.loadNpmTasks('grunt-hash');

I think It's also documented on the Sails.js website

dannysuryadi commented 6 years ago

The sync error is found in sails-hook-grunt/accessible/load-grunt-tasks before it loads any file in the tasks directory. Specifically in the grunt.loadTasks() function when trying to load grunt-sync.

Changing sync.js in the tasks/config doesn't solve this error, even if you delete all files in the tasks directory except tasks/register/default.js, this error still persists.

Edit: I managed to remove the "Loading "sync.js" tasks...ERROR TypeError: Cannot read property 'length' of undefined" error by forking the sails-hook-grunt package, uninstalling the default sails-hook-grunt, installing my forked sails-hook-grunt package, and installing grunt-sync package.

zhoub commented 6 years ago

Bump, latest still has issue issue, please fix this.

streleck commented 6 years ago

@erwinsetiawan This may be a problem of using this version of node, but for now I think it's possible to work around it. In your sails project, in the file tasks/sync.js, there are instructions how to customize the grunt dependencies:

Install it as a local dependency of your Sails app:

$ npm install grunt-sync --save-dev --save-exact
Then uncomment the following code: // // Load Grunt plugin from the node_modules/ folder. // grunt.loadNpmTasks('grunt-sync');

erwinsetiawan commented 6 years ago

@streleck you seems copying on previous comment

ZarcoNontol commented 6 years ago

The sync error is found in sails-hook-grunt/accessible/load-grunt-tasks before it loads any file in the tasks directory. Specifically in the grunt.loadTasks() function when trying to load grunt-sync.

Changing sync.js in the tasks/config doesn't solve this error, even if you delete all files in the tasks directory except tasks/register/default.js, this error still persists.

Edit: I managed to remove the "Loading "sync.js" tasks...ERROR TypeError: Cannot read property 'length' of undefined" error by forking the sails-hook-grunt package, uninstalling the default sails-hook-grunt, installing my forked sails-hook-grunt package, and installing grunt-sync package.

It worked for me. I'm using your fork to fix the problem.

npm install git+https://github.com/dannysuryadi/sails-hook-grunt.git --save-dev --save-exact

This Environment Info (I'm using docker to run my Sailsjs app):

Node: v10.11.0 (FROM node:latest)
Npm: 6.4.1 (FROM node:latest)

emps commented 5 years ago

i have same problem as goin to node 10 lts, im on sails 0.12.4

is there a fix coming ?

emps commented 5 years ago

i have updated "grunt-sync": "0.8.0", with nodejs 10 and all works ok 👍

nicolapalavecino commented 5 years ago

with @streleck it solves the problem but it would be great if within sails the grunt-sync dependency version was updated 👍

Medioman92 commented 5 years ago

this is still a problem

johnabrams7 commented 5 years ago

@Medioman92 What version of sails and grunt-sync are you using? (Node.js v10 yes?)

Medioman92 commented 5 years ago

sails@1.1.0 grunt-sync@0.6.2 OR grunt-sync@0.8.0 Node 10.5.0

The only solution was a downgrade of node to 10.4.1

johnabrams7 commented 5 years ago

@Medioman92 Thanks for confirming this issue (especially that it also occurs on the latest grunt-sync 0.8.0) and confirming the work-around (use Node 10.4.1).

At the moment, there's a Node 10 LTS v10.5.3 that may be worth trying but 10.4.1 is likely the best bet until grunt-sync is specifically updated further.

mike-usa commented 5 years ago

@erwinsetiawan:

@streleck you seems copying on previous comment

I initially thought the same thing, that he was copying @raqem's solution. However, the answers are slightly different. @raqem is suggesting to use a local version of grunt-task and @streleck is suggesting to use a local version of grunt-sync.

In order to use either, they both need to be installed locally and then their respective file in /tasks/config must be modified by uncommenting the respective line.