"sails.getDatastore() is not a function" in Service methods

[dmitrye]

Node version: 10.13.0 Sails version (sails): 1.1.0 ORM hook version (sails-hook-orm): 2.1.0 Sockets hook version (sails-hook-sockets): 1.5.3 Organics hook version (sails-hook-organics): empty Grunt hook version (sails-hook-grunt): not used Uploads hook version (sails-hook-uploads): not used DB adapter & version (e.g. sails-mysql@5.55.5): not used, MongoDB Skipper adapter & version (e.g. skipper-s3@5.55.5): not used

---

Using sails.getDatastore() should be available in Service methods and not just Controllers. Service methods are often used for common DB Interactions as opposed to scattering methods across controller files. Therefore, if someone needs to use custom sails.getDatastore() method it should not just be in the controller.

[sailsbot]

@dmitrye Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

• look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
• tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
• make sure you've provided clear instructions on how to reproduce the bug from a clean install.
• double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
• read the code of conduct.
• if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
• let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

  ---

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

[raqem]

Hi @dmitrye even though Sails supports using services it is highly recommended to use helpers instead. Bonus helpers can use all database model methods.

[dmitrye]

@raqem Interesting choice. Solves the same problem I guess. I use services as a class type that handles specific processing and can contain public/private methods. I'll look at helpers which other than name sounds like it does the same thing.

I also worked around this issue by referencing getDatastore() from the model inside the service.

Works: sails.models["model_name"].getDatastore().manager;

Doesn't work: sails.getDatastore().manager;

For me this works since I'm working against existing models. But other people who may want to execute native queries against the DB without directly referencing the models (multi table native queries, or complex Mongo aggregates) will run into this problem.

[raqem]

@dmitrye Thanks for providing your work around! I hope helpers can live up to your expectations.