`requestQueues` not able to queue more than one request

[MaxDesiatov]

steps to reproduce:

• put something like this in example/index.html

 io.socket.get('/blah', function () {
     console.log('blah');
 });

• start the server in example directory as node server.js
• in a browser open URL http://localhost:1337/example/
• in a browser put a breakpoint at sails.io.js:459 or somewhere at the lines

requestQueues[self.id] = requestQueues[self.id] || [];
requestQueues[self.id].push(request);

• reload the page
• look at the variables at the breakpoint, you'll see that the value of self.id is undefined, so the requests in requestQueues will be overwritten if there are more than one

[mikermcneil]

@explicitcall thanks, Ill take a look!

[mikermcneil]

@explicitcall ok, so first of all, thanks for bringing this to my attention. I did some work here that gets us part of the way there, but there's still some things left to be done to make the request queueing work for multiple sockets. Currently, it's not a use case my team has on our plate so I can't really justify any more time working to make it possible, but I'm more than happy to accept a PR from anyone who needs this feature and has a few minutes to finish the job.

Basically e94e228e68925c4cbd48c5fe5e07de3631b63fb8 sets things up so that each socket instance has a requestQueue. The requestQueue is being run when TmpSocket.prototype.become() gets called. The issue is that TmpSocket is only being instantiated for the initial io.socket and not all other sockets. Basically we just need to return a new TmpSocket instance from our io.connect override, start connecting a real socket (which we already do), then when that realSocket finishes connecting, we need to call fakeSocket.become(realSocket). As I mentioned, this code already exists in the SDK, but as a one-off for io.socket-- the next step is to make it generic.

Thanks again!

[mikermcneil]

Made an issue for the multi-socket use case here so we can go ahead and close this one

[mikermcneil]

@explicitcall just released sails.io.js@v0.10.0-rc4 to npm and bower with this fix (and a few other improvements)

Link: https://github.com/balderdashy/sails.io.js/releases/tag/v0.10.0-rc4

[MaxDesiatov]

thank you! will give it a try