npm audit fail because of sails-mysql@1.0.1 -> npm module braces

[joeherold]

Node version: v10.15.1 Sails version (sails): 1.x DB adapter & version : sails-mysql@1.0.1

---

                        === npm audit security report ===                        

┌──────────────────────────────────────────────────────────────────────────────┐
│                                Manual Review                                 │
│            Some vulnerabilities require your attention to resolve            │
│                                                                              │
│         Visit https://go.npm.me/audit-guide for additional guidance          │
└──────────────────────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Low           │ Regular Expression Denial of Service                         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ braces                                                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=2.3.1                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ sails-mysql                                                  │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ sails-mysql > machinepack-mysql > waterline-sql-builder >    │
│               │ knex > liftoff > findup-sync > micromatch > braces           │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/786                             │
└───────────────┴──────────────────────────────────────────────────────────────┘

[sailsbot]

@joeherold Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

• look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
• tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
• make sure you've provided clear instructions on how to reproduce the bug from a clean install.
• double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
• read the code of conduct.
• if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
• let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

  ---

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

[johnabrams7]

@joeherold Thanks for letting us know. I confirmed the npm audit vulnerability with the latest sails-mysql and made a note to have it checked out. In the meantime, we have an alternative/newer mysql/mssql/postgresql supported adapter sails-sql that isn't getting any vulnerability reports from npm audit 👍. At the moment postgresql is the primary db support in development for that adapter, mysql should be ready for production.

[joeherold]

@johnabrams7 thanks for the information. but sails-sql sais:

THIS IS A WORK IN PROGRESS UNDER ACTIVE DEVELOPMENT - DO NOT USE IN PRODUCTION

I just came across using it with my current project @apollo-waterline/server and wanted to avoid an install warning. I will check out sails-sql, even though

[whichking]

@joeherold—

That's true generally—and it's certainly the case for PostgreSQL—but the MySql implementation of sails-sql is production-ready!