FindOne() does not honor multiple where()

[grd2345]

Node version: v8.16.0 Sails version (sails): 1.2.3 ORM hook version (sails-hook-orm): 2.1.1 Sockets hook version (sails-hook-sockets): 1.5.5 Grunt hook version (sails-hook-grunt): 1.0.8 DB adapter & version (e.g. sails-mysql@5.55.5): 1.0.2

---

I am in the process of migrating to version 1 and their is a breaking change that I did not see on the migration documents. This used to work in the prior version.

Agreement.findOne() .where({id: agreementId}) .where({locationId: employee.currentLocation.id})

Now this fails with

More than one matching record found for .findOne():

I stepped through the adapter code and it ignores all .where() except the last where, which is an issue.

[sailsbot]

@grd2345 Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

• look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
• tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
• make sure you've provided clear instructions on how to reproduce the bug from a clean install.
• double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
• read the code of conduct.
• if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
• let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

  ---

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

[grd2345]

Just a note, this issue is occuring also using Find() with multiple where(). It does not honor multiple where anymore.Is this by design or a bug.

[steinathan]

Hi @grd2345 honestly the word findOne means find only one document in the DB, with a specific attribute that matches only one record [eg -> id], if multiple records was matched sails would panic, which means that duplicates records was entered twice somehow, this is not actually related to FindOne() honoring multiple where() clause. rewriting your code with one .where({ id: agreementId, locationId: employee.currentLocation.id }) will still throw this error, this is a common problem i've faced with sails in the past, but a work around is dope!

[johnabrams7]

@grd2345 Thanks for bringing this to attention! @navicstein Thanks for the response as well! find() is indeed recommended for multiple results - while findOne() is designed for a single result. As for defining multiple criteria with where() (combined with find()), these are specified within a single where() clause.

Sails console example: Agreement.find()({where: {id: agreementId, locationId: employee.currentLocation.id}}).log()

[grd2345]

thanks, yes, I refactored to not use chain-able where clauses anymore. just wanted to inform that version prior to v1 allowed chainable where clauses and not anymore.

Thanks for everything.

[johnabrams7]

@grd2345 Ah, yes Sails 1.x has breaking changes for how waterline handles where(). Glad it worked out!