sails-mongo reconnectTries does not reconnect

cope commented 5 years ago

Node version: v8.15.0 Sails version (sails): 0.12.14 ORM hook version (sails-hook-orm): 1.0.9 Sockets hook version (sails-hook-sockets): 0.13.14 Organics hook version (sails-hook-organics): - Grunt hook version (sails-hook-grunt): - Uploads hook version (sails-hook-uploads): - DB adapter & version (e.g. sails-mysql@5.55.5): - Skipper adapter & version (e.g. skipper-s3@5.55.5): 0.7.6

I added autoReconnect and auto_reconnect, based on some issues and pull request comments I found, and I also added reconnectTries - tried with both Number.MAX_VALUE and 1000000 - but no matter what, it still does not reconnect when mongo is restarted :(

    mongodb: {
        adapter: 'sails-mongo',
        port: 27017,
        host: 'localhost',
        database: 'myapp',
        autoReconnect: true,
        auto_reconnect: true,
        reconnectTries: 1000000

I think the error I get may shed some light:

error: Error occurred in session middleware :: 'MongoError: no connection available for operation\n at Function.MongoError.create (C:\\git\\systools\\myapp\\node_modules\\connect-mongo\\node_modules\\mongodb-core\\lib\\error.js:31:11)\n at Store.flush (C:\\git\\systools\\myapp\\node_modules\\connect-mongo\\node_modules\\mongodb\\lib\\topology_base.js:68:43)\n at Server.destroyHandler (C:\\git\\systools\\myapp\\node_modules\\connect-mongo\\node_modules\\mongodb\\lib\\server.js:258:18)\n at Object.onceWrapper (events.js:315:30)\n at emitOne (events.js:116:13)\n at Server.emit (events.js:211:7)\n at Server.destroy (C:\\git\\systools\\myapp\\node_modules\\connect-mongo\\node_modules\\mongodb-core\\lib\\topologies\\server.js:673:24)\n at reconnectServer (C:\\git\\systools\\myapp\\node_modules\\connect-mongo\\node_modules\\mongodb-core\\lib\\topologies\\server.js:162:17)\n at Timeout._onTimeout (C:\\git\\systools\\myapp\\node_modules\\connect-mongo\\node_modules\\mongodb-core\\lib\\topologies\\server.js:272:7)\n at ontimeout (timers.js:498:11)\n at tryOnTimeout (timers.js:323:5)\n at Timer.listOnTimeout (timers.js:290:5)'

Particularly the at Server.destroy part... I guess the server is shutting down, but I don't know why?

sailsbot commented 5 years ago

@cope Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
make sure you've provided clear instructions on how to reproduce the bug from a clean install.
double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
read the code of conduct.
if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

Jopchumba commented 5 years ago

Please read the errors first, the issues might be here you don't have the mongo plugin instaled in your project

johnabrams7 commented 5 years ago

@cope To confirm, does this work & connect if you remove reconnectTries ?

cope commented 5 years ago

@johnabrams7 yes, I just did. But, as soon as this error happens, no more reconnect.

error: Error occurred in session middleware :: 'MongoError: no connection available for operation\n at Function.MongoError.create (C:\git\systools\myapp\node_modules\connect-mongo\node_modules\mongodb-core\lib\error.js:31:11)\n at Store.flush (C:\git\systools\myapp\node_modules\connect-mongo\node_modules\mongodb\lib\topology_base.js:68:43)\n at Server.destroyHandler (C:\git\systools\myapp\node_modules\connect-mongo\node_modules\mongodb\lib\server.js:258:18)\n at Object.onceWrapper (events.js:315:30)\n at emitOne (events.js:116:13)\n at Server.emit (events.js:211:7)\n at Server.destroy (C:\git\systools\myapp\node_modules\connect-mongo\node_modules\mongodb-core\lib\topologies\server.js:673:24)\n at reconnectServer (C:\git\systools\myapp\node_modules\connect-mongo\node_modules\mongodb-core\lib\topologies\server.js:162:17)\n at Timeout._onTimeout (C:\git\systools\myapp\node_modules\connect-mongo\node_modules\mongodb-core\lib\topologies\server.js:272:7)\n at ontimeout (timers.js:498:11)\n at tryOnTimeout (timers.js:323:5)\n at Timer.listOnTimeout (timers.js:290:5)' WebSocket client disconnected. qMJ2lIHfjxexExOuAAAB

johnabrams7 commented 4 years ago

@cope Interesting, if it's giving an error either way - there may be another factor involved. Could you make a minimal Sails 0.12x repo that reproduces this issue?

balderdashy / sails

sails-mongo reconnectTries does not reconnect #6878