One-to-many create parent + childs fails

[lreyessandoval]

Node version: v12.13.0 Sails version (sails): 1.2.3 DB adapter & version : sails-mysql@5.7.23-cll-lve

---

I have a model User (Parent):

/**
 * User.js
 *
 * @description :: A model definition represents a database table/collection.
 * @docs        :: https://sailsjs.com/docs/concepts/models-and-orm/models
 */

module.exports = {
  attributes: {
    firstName: {
      type: 'string'
    },
    lastName: {
      type: 'string'
    },

    // Add a reference to Pets
    pets: {
      collection: 'pet',
      via: 'owner'
    }
  }
};

And Model Pet (Child):

/**
 * Pet.js
 *
 * @description :: A model definition represents a database table/collection.
 * @docs        :: https://sailsjs.com/docs/concepts/models-and-orm/models
 */

module.exports = {
  attributes: {
    breed: {
      type: 'string'
    },
    type: {
      type: 'string'
    },
    name: {
      type: 'string'
    },

    // Add a reference to User
    owner: {
      model: 'user'
    }
  }
};

Find/FindAll populating works fine, but when I try to create a header (User) and details (Pet) an error appears.

**POST: http://localhost:1337/User ** 
{
    "firstName": "Luis",
    "lastName": "Reyes",
    "pets": [
        {
            "breed": "labrador",
            "type": "dog",
            "name": "Princesa"
        },
        {
            "breed": "labrador",
            "type": "dog",
            "name": "Luna"
        }
    ]
}

This is the error that returns:

UsageError: Invalid criteria.
Details:
Could not use the provided `where` clause. Could not filter by `id`: Invalid item within `in` modifier array. Does not
match the declared data type of the corresponding attribute. 1 error validating value:
• Specified value (a dictionary: { breed: 'labrador', type: 'dog', name: 'Princesa' }) doesn't match the expected type:
'number'

at D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\lib\hooks\blueprints\actions\create.js:53:45
at D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:2489:9
at replenish (D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:946:17)
at iterateeCallback (D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:931:17)
at D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:906:16
at D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:2491:13
at D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\lib\hooks\blueprints\actions\create.js:71:14
at D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:2489:9
at replenish (D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:946:17)
at iterateeCallback (D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:931:17)
at D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:906:16
at D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:2491:13
at D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\lib\hooks\blueprints\actions\create.js:71:14
at D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:2489:9
at replenish (D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:946:17)
at iterateeCallback (D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:931:17)
at D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:906:16
at D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:2491:13
at D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\lib\hooks\blueprints\actions\create.js:71:14
at D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:2489:9
at replenish (D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:946:17)
at iterateeCallback (D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:931:17)
at D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:906:16
at D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:2491:13
at D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\lib\hooks\blueprints\actions\create.js:71:14
at D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:2489:9
at replenish (D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:946:17)
at iterateeCallback (D:\2.- Desarrollo\poc\backend\apierp\node_modules\sails\node_modules\async\dist\async.js:931:17)

[sailsbot]

@lreyessandoval Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

• look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
• tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
• make sure you've provided clear instructions on how to reproduce the bug from a clean install.
• double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
• read the code of conduct.
• if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
• let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

  ---

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

[whichking]

Hey, @lreyessandoval! I believe the functionality you're looking for isn't supported in Sails v1. Per the upgrade guide:

The .create(), .update() and .add() model methods no longer support creating a new “child” record to link immediately to a new or existing parent. For example, given a User model with a singular association to an Animal model through an attribute called pet, it is not possible to set pet to a dictionary representing values for a brand new Animal (aka a “nested create”). Instead, create the new Animal first and use its primary key to set pet when creating the new User.

[lreyessandoval]

Thanks, I will look for a workarround for this case ...

Is there a date to release this functionality in a next release?

[whichking]

@lreyessandoval—from what I understand, this functionality was supported in older (pre-v1) versions of Sails. I don't think that there are any plans to revive it for future versions.