balderdashy / sails

Realtime MVC Framework for Node.js
https://sailsjs.com
MIT License
22.84k stars 1.95k forks source link

How can i exclude the specific model from auto-migration. #6935

Open satishverma143 opened 4 years ago

satishverma143 commented 4 years ago

How can I exclude the specific model from auto-migration in sails v1.0 I have tried to add migrate: 'safe' in the model. but it's not working.

Node version: v10.15.3 Sails version (sails): 1.0.0 ORM hook version (sails-hook-orm): 2.0.0-16 Sockets hook version (sails-hook-sockets): 1.4.0 Grunt hook version (sails-hook-grunt): 3.0.2 DB adapter & version (e.g. sails-mysql@5.55.5): 1.0.1


sailsbot commented 4 years ago

@satishverma143 Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

whichking commented 4 years ago

Hey, @satishverma143!

The migrate model setting can actually only be set in config.models.js as an app-wide default. Although this behavior isn't currently expressed in the documentation, it is expected. Here's the PR that adds that language to the docs.

You might find the discussion on this related GitHub issue to be of some use.

Lovinity commented 1 year ago

@whichking

I fail to understand why the constraint.

Here is a use case where it is necessary to have model-specific migration settings: I have a Sails application that not only uses its own database but shares use of a database with a separate non-Sails application (this is necessary functionality for the Sails app to do as it was intended; the other app's API is not robust enough to access everything I need to without directly using the database. As the other app is closed source, I cannot change this.). It should be able to migrate its own database, but I should force migration to safe on the database used by the other application (otherwise the other application stops working).

Here is potential desired functionality to conform with safety standards for production:

DominusKelvin commented 1 year ago

Hey @Lovinity in production migration is always set to safe. Doesn't this work for your use case?

Lovinity commented 1 year ago

Hey @Lovinity in production migration is always set to safe. Doesn't this work for your use case?

It works in production. But say I, or a future engineer, need to re-create or alter the database for the Sails app by running in development. If Sails has models for a database shared with another application, those models (tables) will get modified by migration, which is undesired and may cause the other application to stop working. There is no other way to do this in my use case; I would ideally use an API to communicate with the application instead of directly in the database. Unfortunately, the API for the other application does not have enough coverage. So I'm forced to work with the database directly.