Middleware not always called

[LouAdrien]

.Node version: 11.0.0 Sails version (sails): 1.2.3 ORM hook version (sails-hook-orm): 2.1.1 Sockets hook version (sails-hook-sockets): 2.0.0 Organics hook version (sails-hook-organics): 0.16.1 Grunt hook version (sails-hook-grunt): 4.0.1 Uploads hook version (sails-hook-uploads): not present DB adapter & version (e.g. sails-mysql@5.55.5): sails-mongo@1.0.1 Skipper adapter & version (e.g. skipper-s3@5.55.5): skipper-disk@0.5.12

---

In the example below, customCORS middleware will not be called on every route, for example if you create a User model, the blueprint GET route will not call customCORS. If I put customCORS first in the order, it will be called. Is that normal behavior? The documentation states the middlewares will ALWAYS be called.

(more readable version here : https://gist.github.com/LouAdrien/b2021f8c990b7ba067979c38e52e9662) `

module.exports.http = {

middleware: { order: [ // Putting custom CORS middleware twice as it seems it sometimes NOT get called, but sometime the cros headers get rewritten in the middle. 'cookieParser', 'session', 'bodyParser', 'compress', 'poweredBy', 'router', 'www', 'favicon', // Putting custom CORS middleware twice as it seems it sometimes NOT get called, but sometime the cros headers get rewritten in the middle. 'customCORS', ],

customCORS : function (req,res,next) {
    console.log('Received HTTP request: '+req.method+' '+req.path);
    var authorizedOrigin = 'http://localhost:4200';
    if ( sails.config.custom.customAllowAllOrigin ) {
      authorizedOrigin = req.headers.origin;
    }

    res.set({
      'Access-Control-Allow-Origin': authorizedOrigin,
      'Access-Control-Allow-Credentials': true,
      'Access-Control-Allow-Methods': 'GET,HEAD,PUT,PATCH,POST,DELETE,OPTIONS',
      'Access-Control-Allow-Headers': 'Content-Type, *'
    });

    return next();
  },

/***************************************************************************
*                                                                          *
* The body parser that will handle incoming multipart HTTP requests.       *
*                                                                          *
* https://sailsjs.com/config/http#?customizing-the-body-parser             *
*                                                                          *
***************************************************************************/

// bodyParser: (function _configureBodyParser(){
//   var skipper = require('skipper');
//   var middlewareFn = skipper({ strict: true });
//   return middlewareFn;
// })(),

},

};

`

[sailsbot]

@LouAdrien Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

• look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
• tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
• make sure you've provided clear instructions on how to reproduce the bug from a clean install.
• double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
• read the code of conduct.
• if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
• let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

  ---

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

[johnabrams7]

Hey @LouAdrien, appreciate all the info on this. Having the team check it out.

Is this also an issue with non-blueprint routes as well, or only when using blueprints?