Express error middleware doesn't seem to be used

[strugee]

Node version: 10.21.0 Sails version (sails): 1.2.4 ORM hook version (sails-hook-orm): 2.1.1 Sockets hook version (sails-hook-sockets): not installed, although there are some lingering bits from when it was Organics hook version (sails-hook-organics): not installed Grunt hook version (sails-hook-grunt): 4.0.0 Uploads hook version (sails-hook-uploads): not installed DB adapter & version (e.g. sails-mysql@5.55.5): sails-postgresql@1.0.2 (though I've been reproducing this using sails-disk in development) Skipper adapter & version (e.g. skipper-s3@5.55.5): not installed (I think?)

---

Given the following in config/http.js:

  middleware: {
     order: [
       'cookieParser',
       'session',
       'bodyParser',
       'compress',
       'poweredBy',
       'router',
       'www',
       'favicon',
       'testError'
     ],

    testError: function(err, req, res, next) {
      sails.log.error('Test error');
      throw new Error('test error');
    }
  }

Any HTTP 500 error seems like it should cause Test error to be logged to the console, followed by an additional test error stack trace. But I don't see anything.

Am I meant to be using https://sailsjs.com/documentation/reference/response-res/res-server-error? This would probably work but feels wrong - for context, what I'm really trying to do is use Sentry's Express integration in my Sails app. So what I care about is not 500 errors per se, but instead just any error generated during request processing (though I admit that in the end for almost all apps these turn into 500 errors anyway). The middleware ordering also matters; I need this error middleware to be run before any other error middleware.

[sailsbot]

@strugee Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

• look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
• tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
• make sure you've provided clear instructions on how to reproduce the bug from a clean install.
• double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
• read the code of conduct.
• if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
• let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

  ---

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

[strugee]

* Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails.  But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.

Also as a P.S. to my bug report: thank you for maintaining Sails <3

I've just started using it after using bare Express for a long time and I gotta say, I'm starting to really like it.

[eashaw]

Hi @strugee, thank you for your interest in Sails

Am I meant to be using https://sailsjs.com/documentation/reference/response-res/res-server-error?

YES! If you want to handle non 5XX errors, stick that in all of your custom response files (how you do this will affect the order)