Proposal: make Waterline encryption-at-rest run after beforeCreate lifecycle callback

[neonexus]

Node version: 14.5.0 (any really) Sails version (sails): 1.2.4 ORM hook version (sails-hook-orm): 3.0.1 (I think this is where my issue is) Sockets hook version (sails-hook-sockets): N/A Organics hook version (sails-hook-organics): N/A Grunt hook version (sails-hook-grunt): N/A Uploads hook version (sails-hook-uploads): N/A DB adapter & version (e.g. sails-mysql@5.55.5): N/A Skipper adapter & version (e.g. skipper-s3@5.55.5): N/A

---

Preface

So, I know this is overkill, but frankly, overkill security is sometimes needed; but there is a second use-case I will describe after my current delima, that I think should be discussed.

My thoughts

So, I want to hash passwords with Scrypt KDF, then have said hash encrypted via Waterline's encryption system. Again, I know it's a bit of overkill, but here is my train of thought: why WOULDN'T you mix the 2? Hashes still have the inherent problem of being able to be compared, even with Scrypt KDF with salts. All it takes is MASSIVE computing power (which isn't hard anymore with crypto). And since it is meant to be validated, it's a simple yes / no problem. BUT, if you encrypt the hashes, suddenly there is a ton more complexity to solving the problem (which very quickly renders brute-forcing basically use-less).

So what's the actual problem?

Waterline, for some reason, is encrypting whatever BEFORE the beforeCreate / beforeUpdate functions. This is a big headache, because now I have to move my password hashing to the controllers (or a helper), when I feel like it should be the job of the model to handle this level of work. Why are things encrypted BEFORE beforeCreate?

My final thoughts

What if, I want to deal with a field, where if it is blank on creation, I generate it, (or hell, even modify the value on create / update) then wanted it encrypted? I don't believe I can do that, seeing as things are encrypted BEFORE beforeCreate is called... So again, I ask why? Why are fields encrypted BEFORE beforeCreate and beforeUpdate? I would most certainly expect them encrypted BEFORE afterCreate / afterUpdate, and AFTER beforeCreate / beforeUpdate...

For reference, here is the model (or a version of it) I'm describing: https://github.com/neonexus/sails-react-bootstrap-webpack/blob/release/api/models/User.js

[sailsbot]

@neonexus Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

• look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
• tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
• make sure you've provided clear instructions on how to reproduce the bug from a clean install.
• double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
• read the code of conduct.
• if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
• let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

  ---

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

[neonexus]

After 2 years, can I get another look at this? I would love to get this fixed, but I can't seem to find where this is happening down the pipeline.