Sails's v1.5.1 routeTargetFnWrapper middleware consuming upwards of 7 seconds when number of request suddenly increases

[barshan23]

We're running Sail.js(v1.5.1) app. We're seeing a recent uptick in time consumptions by the routeTargetFnWrapper middleware whenever there is a sudden 2x or 3x ( from 50rpm to 100 or 150rpm) increase in number of requests.

We're getting this data via New Relic.

Is it something known ?

Node version: 10.14 Sails version sails: 1.5.1 ORM hook version sails-hook-orm: 4.0.1 Sockets hook version sails-hook-sockets: 2.0.1 DB adapter & version sails-mysql: 1.0.3 & DB version: MySQL@5.7.26 Skipper adapter & version skipper: "0.9.1",

---

[sailsbot]

@barshan23 Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

• look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
• tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
• make sure you've provided clear instructions on how to reproduce the bug from a clean install.
• double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
• read the code of conduct.
• if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
• let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

  ---

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

[eashaw]

Hi @barshan23, We recommend you analyze the action that is being called by the route.

You can start the server withDEBUG=true sails lift for more detail in your stack trace.

[ashuvyas45]

@barshan23 i am facing the similar issue. Are you able to find any root cause for this?

[HK321]

@barshan23 @eashaw I am facing the same issue; when the request rate increases, the middleware takes more time.

[harisrt]

Guys, is there any update on this?

[eashaw]

Hi everyone, to help us properly diagnose this error, can you share the code of the action you're seeing this issue in?

[rupeshpadhye]

Hi @eashaw , On production we also facing similar issue , API calls are stuck in middleware. can you guide what can be helpful to you to diagnose the issue

[eashaw]

Hi @rupeshpadhye, would you be able to share an example of the code where you're seeing this issue?

[HK321]

Hey @eashaw,

In my case, the problem wasn't with the middleware. Using CDNs reduced the response time to 70-80ms from 500-600ms, so the problem was related to the region of the server and client. I am leaving this here for others incase they face this issue because of a similar reason.

[rupeshpadhye]

After investing a bit, the issue wasn't related with sails framework. New Relic not able to log the complete trace if the API get's timeouts and adds associate the the time with middleware.

thanks!