balderdashy / sails

Realtime MVC Framework for Node.js
https://sailsjs.com
MIT License
22.85k stars 1.95k forks source link

MariaDB support in documentation? #7346

Open robertsilen opened 2 months ago

robertsilen commented 2 months ago

Hello, does sails support MariaDB? I noticed that MySQL is mentioned in the README and e.g. on the available adapters docs page. Any reason not to add MariaDB? Its the default in most distros so only seems fair, and it eliminates any doubts about compatibility.

sailsbot commented 2 months ago

@robertsilen Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

Maxed0utt commented 2 months ago

Hello, does sails support MariaDB? I noticed that MySQL is mentioned in the README and e.g. on the available adapters docs page. Any reason not to add MariaDB? Its the default in most distros so only seems fair, and it eliminates any doubts about compatibility.

I use the mysql adapter with mariadb all the time in my sails apps, have had no issues!

robertsilen commented 1 month ago

Cool! I'd do love to change the README to read "Officially supported databases include MariaDB and MySQL" (with the link to the sails-mysql adapter - any reason not to?

robertsilen commented 1 month ago

Made a PR: https://github.com/balderdashy/sails/pull/7352