balderdashy / waterline-adapter-tests

API integration tests for Waterline adapters
MIT License
16 stars 41 forks source link

Replace assert(!err) with assert.ifError(err) #103

Closed kevinburkeshyp closed 8 years ago

kevinburkeshyp commented 8 years ago

If an error is present, assert(!err) reports that false was expected to be true, which means you have to re-run the test and print the error to actually figure out what the error was. assert.ifError(err) fails if the error is defined and will print the error if one is present, which means you don't have to re-run the tests to figure out what went wrong.

particlebanana commented 8 years ago

This is great, thanks @kevinburkeshyp :raised_hands: