search

balderdashy / waterline-adapter-tests

API integration tests for Waterline adapters
MIT License
16 stars 41 forks source link

fix: `waterline` dependency is pointing to GitHub. Should it point to an npm version? #111

Open luislobo opened 1 year ago

luislobo commented 1 year ago

I've been working on sails-mongo, and on some occasions when testing npm caching, I was getting a weird git error:

npm ERR! code 128
npm ERR! An unknown git error occurred
npm ERR! command git --no-replace-objects ls-remote ssh://git@github.com/balderdashy/waterline.git
npm ERR! No user exists for uid [10](https://github.com/luislobo/sails-mongo/actions/runs/5040708917/jobs/9039730428#step:6:11)01
npm ERR! fatal: Could not read from remote repository.
npm ERR! 
npm ERR! Please make sure you have the correct access rights
npm ERR! and the repository exists.

npm ERR! A complete log of this run can be found in:
npm ERR!     /github/home/.npm/_logs/[20](https://github.com/luislobo/sails-mongo/actions/runs/5040708917/jobs/9039730428#step:6:21)23-05-22T01_10_22_639Z-debug-0.log

After digging a little I saw that this repo is requiring waterline from GitHub. Is this really necessary?